Make GroupedPermissionInfoBarDelegate's methods call through PermissionPromptAndroid

chrome/browser/permissions/grouped_permission_infobar_delegate_android.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PERMISSIONS_GROUPED_PERMISSION_INFOBAR_DELEGATE_ANDROID_H_
 #define CHROME_BROWSER_PERMISSIONS_GROUPED_PERMISSION_INFOBAR_DELEGATE_ANDROID_H_
 
 #include <memory>
 
 #include "base/callback.h"
 #include "components/content_settings/core/common/content_settings_types.h"
 #include "components/infobars/core/confirm_infobar_delegate.h"
 
 class GURL;
 class InfoBarService;
+class PermissionPromptAndroid;
 class PermissionRequest;
 
 // An InfoBar that displays a group of permission requests, each of which can be
 // allowed or blocked independently.
 // TODO(tsergeant): Expand this class so it can be used without subclassing.
 class GroupedPermissionInfoBarDelegate : public ConfirmInfoBarDelegate {
  public:
   // Public so we can have std::unique_ptr<GroupedPermissionInfoBarDelegate>.
   ~GroupedPermissionInfoBarDelegate() override;
 
   static infobars::InfoBar* Create(
+      PermissionPromptAndroid* permission_prompt,
       InfoBarService* infobar_service,
       const GURL& requesting_origin,
       const std::vector<PermissionRequest*>& requests);
 
   bool persist() const { return persist_; }
   void set_persist(bool persist) { persist_ = persist; }
   size_t permission_count() const { return requests_.size(); }
 
   // Returns true if the infobar should display a toggle to allow users to
   // opt-out of persisting their accept/deny decision.
   bool ShouldShowPersistenceToggle() const;
 
   ContentSettingsType GetContentSettingType(size_t position) const;
   int GetIconIdForPermission(size_t position) const;
 
   // Message text to display for an individual permission at |position|.
   base::string16 GetMessageTextFragment(size_t position) const;
 
   // Toggle accept value for an individual permission at |position|.
   void ToggleAccept(size_t position, bool new_value);
 
   // ConfirmInfoBarDelegate:
   base::string16 GetMessageText() const override;
+  bool Accept() override;
+  bool Cancel() override;
 
  protected:
   bool GetAcceptState(size_t position);
 
  private:
   GroupedPermissionInfoBarDelegate(
       const GURL& requesting_origin,
-      const std::vector<PermissionRequest*>& requests);
+      const std::vector<PermissionRequest*>& requests,
+      PermissionPromptAndroid* permission_prompt);
 
   // ConfirmInfoBarDelegate:
   InfoBarIdentifier GetIdentifier() const override;
   Type GetInfoBarType() const override;
   int GetButtons() const override;
   base::string16 GetButtonLabel(InfoBarButton button) const override;
 
   const GURL requesting_origin_;
   const std::vector<PermissionRequest*> requests_;
   std::vector<bool> accept_states_;
   // Whether the accept/deny decision is persisted.
   bool persist_;
+  // PermissionPromptAndroid's lifetime matches that of this object as it
+  // controls the lifetime of the infobar which we are a delegate to.

[raymes, 2016/10/27 01:32:33]

Hmm - it's not immediately clear to me that the PermissionPromptAndroid's
lifetime will outlast the InfoBar's lifetime, since the InfoBar is actually
managed by the InfoBarService. For example, even calling RemoveInfobar won't
necessarily cause the Infobar to be deleted synchronously. I wonder if we need
to hold a WeakPtr here? I'm not certain though - it's not simple to reason about
at least. Do you or Dom have any insights?

[lshang, 2016/10/28 03:18:48]

I think your point makes sense, that's a tricky one. PermissionRequestManager
will delete PermissionPrompt after calls to hide bubble, but I'm not sure if
user could still interact with bubble's buttons during this time, or the bubble
close animation got delayed for some reason. 

Use WeakPtr should be safer. Or we could also dynamically get PermissionPrompt
from PermissionRequestManager to see if it has been destroyed or not.

+  PermissionPromptAndroid* permission_prompt_;
 
   DISALLOW_COPY_AND_ASSIGN(GroupedPermissionInfoBarDelegate);
 };
 
 #endif  // CHROME_BROWSER_PERMISSIONS_GROUPED_PERMISSION_INFOBAR_DELEGATE_ANDROID_H_