Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6263)

Unified Diff: chrome/browser/ui/website_settings/website_settings.h

Issue 2440183002: Initialize all fields in WebsiteSettings. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/website_settings.h
diff --git a/chrome/browser/ui/website_settings/website_settings.h b/chrome/browser/ui/website_settings/website_settings.h
index f2606784f7e3ab360423194bcda40950bd31e035..9434581a93df193c2cfdcd06e857f875a351d026 100644
--- a/chrome/browser/ui/website_settings/website_settings.h
+++ b/chrome/browser/ui/website_settings/website_settings.h
@@ -181,20 +181,20 @@ class WebsiteSettings : public TabSpecificContentSettings::SiteDataObserver,
// The flag that controls whether an infobar is displayed after the website
// settings UI is closed or not.
- bool show_info_bar_;
+ bool show_info_bar_ = false;
// The Omnibox URL of the website for which to display site permissions and
// site information.
GURL site_url_;
// Status of the website's identity verification check.
- SiteIdentityStatus site_identity_status_;
+ SiteIdentityStatus site_identity_status_ = SITE_IDENTITY_STATUS_UNKNOWN;
// For secure connection |certificate_| is set to the server certificate.
scoped_refptr<net::X509Certificate> certificate_;
// Status of the connection to the website.
- SiteConnectionStatus site_connection_status_;
+ SiteConnectionStatus site_connection_status_ = SITE_CONNECTION_STATUS_UNKNOWN;
// TODO(markusheintz): Move the creation of all the base::string16 typed UI
// strings below to the corresponding UI code, in order to prevent
@@ -210,7 +210,7 @@ class WebsiteSettings : public TabSpecificContentSettings::SiteDataObserver,
// Chrome UI). When |show_ssl_decision_revoke_button| is true, the connection
// area of the page info will include an option for the user to revoke their
// decision to bypass the SSL error for this host.
- bool show_ssl_decision_revoke_button_;
+ bool show_ssl_decision_revoke_button_ = false;
// Details about the connection to the website. In case of an encrypted
// connection |site_connection_details_| contains encryption details, like
@@ -232,7 +232,7 @@ class WebsiteSettings : public TabSpecificContentSettings::SiteDataObserver,
// decisions by users.
ChromeSSLHostStateDelegate* chrome_ssl_host_state_delegate_;
- bool did_revoke_user_ssl_decisions_;
+ bool did_revoke_user_ssl_decisions_ = false;
Profile* profile_;

Powered by Google App Engine
This is Rietveld 408576698