Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Side by Side Diff: chrome/browser/ui/website_settings/website_settings.h

Issue 2440183002: Initialize all fields in WebsiteSettings. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_ 5 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_
6 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_ 6 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "chrome/browser/content_settings/tab_specific_content_settings.h" 10 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 void PresentSiteIdentity(); 174 void PresentSiteIdentity();
175 175
176 // The website settings UI displays information and controls for site- 176 // The website settings UI displays information and controls for site-
177 // specific data (local stored objects like cookies), site-specific 177 // specific data (local stored objects like cookies), site-specific
178 // permissions (location, pop-up, plugin, etc. permissions) and site-specific 178 // permissions (location, pop-up, plugin, etc. permissions) and site-specific
179 // information (identity, connection status, etc.). 179 // information (identity, connection status, etc.).
180 WebsiteSettingsUI* ui_; 180 WebsiteSettingsUI* ui_;
181 181
182 // The flag that controls whether an infobar is displayed after the website 182 // The flag that controls whether an infobar is displayed after the website
183 // settings UI is closed or not. 183 // settings UI is closed or not.
184 bool show_info_bar_; 184 bool show_info_bar_ = false;
185 185
186 // The Omnibox URL of the website for which to display site permissions and 186 // The Omnibox URL of the website for which to display site permissions and
187 // site information. 187 // site information.
188 GURL site_url_; 188 GURL site_url_;
189 189
190 // Status of the website's identity verification check. 190 // Status of the website's identity verification check.
191 SiteIdentityStatus site_identity_status_; 191 SiteIdentityStatus site_identity_status_ = SITE_IDENTITY_STATUS_UNKNOWN;
192 192
193 // For secure connection |certificate_| is set to the server certificate. 193 // For secure connection |certificate_| is set to the server certificate.
194 scoped_refptr<net::X509Certificate> certificate_; 194 scoped_refptr<net::X509Certificate> certificate_;
195 195
196 // Status of the connection to the website. 196 // Status of the connection to the website.
197 SiteConnectionStatus site_connection_status_; 197 SiteConnectionStatus site_connection_status_ = SITE_CONNECTION_STATUS_UNKNOWN;
198 198
199 // TODO(markusheintz): Move the creation of all the base::string16 typed UI 199 // TODO(markusheintz): Move the creation of all the base::string16 typed UI
200 // strings below to the corresponding UI code, in order to prevent 200 // strings below to the corresponding UI code, in order to prevent
201 // unnecessary UTF-8 string conversions. 201 // unnecessary UTF-8 string conversions.
202 202
203 // Details about the website's identity. If the website's identity has been 203 // Details about the website's identity. If the website's identity has been
204 // verified then |site_identity_details_| contains who verified the identity. 204 // verified then |site_identity_details_| contains who verified the identity.
205 // This string will be displayed in the UI. 205 // This string will be displayed in the UI.
206 base::string16 site_identity_details_; 206 base::string16 site_identity_details_;
207 207
208 // Set when the user has explicitly bypassed an SSL error for this host or 208 // Set when the user has explicitly bypassed an SSL error for this host or
209 // explicitly denied it (the latter of which is not currently possible in the 209 // explicitly denied it (the latter of which is not currently possible in the
210 // Chrome UI). When |show_ssl_decision_revoke_button| is true, the connection 210 // Chrome UI). When |show_ssl_decision_revoke_button| is true, the connection
211 // area of the page info will include an option for the user to revoke their 211 // area of the page info will include an option for the user to revoke their
212 // decision to bypass the SSL error for this host. 212 // decision to bypass the SSL error for this host.
213 bool show_ssl_decision_revoke_button_; 213 bool show_ssl_decision_revoke_button_ = false;
214 214
215 // Details about the connection to the website. In case of an encrypted 215 // Details about the connection to the website. In case of an encrypted
216 // connection |site_connection_details_| contains encryption details, like 216 // connection |site_connection_details_| contains encryption details, like
217 // encryption strength and ssl protocol version. This string will be 217 // encryption strength and ssl protocol version. This string will be
218 // displayed in the UI. 218 // displayed in the UI.
219 base::string16 site_connection_details_; 219 base::string16 site_connection_details_;
220 220
221 // For websites that provided an EV certificate |orgainization_name_| 221 // For websites that provided an EV certificate |orgainization_name_|
222 // contains the organization name of the certificate. In all other cases 222 // contains the organization name of the certificate. In all other cases
223 // |organization_name| is an empty string. This string will be displayed in 223 // |organization_name| is an empty string. This string will be displayed in
224 // the UI. 224 // the UI.
225 base::string16 organization_name_; 225 base::string16 organization_name_;
226 226
227 // The |HostContentSettingsMap| is the service that provides and manages 227 // The |HostContentSettingsMap| is the service that provides and manages
228 // content settings (aka. site permissions). 228 // content settings (aka. site permissions).
229 HostContentSettingsMap* content_settings_; 229 HostContentSettingsMap* content_settings_;
230 230
231 // Service for managing SSL error page bypasses. Used to revoke bypass 231 // Service for managing SSL error page bypasses. Used to revoke bypass
232 // decisions by users. 232 // decisions by users.
233 ChromeSSLHostStateDelegate* chrome_ssl_host_state_delegate_; 233 ChromeSSLHostStateDelegate* chrome_ssl_host_state_delegate_;
234 234
235 bool did_revoke_user_ssl_decisions_; 235 bool did_revoke_user_ssl_decisions_ = false;
236 236
237 Profile* profile_; 237 Profile* profile_;
238 238
239 DISALLOW_COPY_AND_ASSIGN(WebsiteSettings); 239 DISALLOW_COPY_AND_ASSIGN(WebsiteSettings);
240 }; 240 };
241 241
242 #endif // CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_ 242 #endif // CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698