Initialize all fields in WebsiteSettings.

Initialize all fields in WebsiteSettings.

show_ssl_decision_revoke_button_ field was never assigned when
constructing WebsiteSettings with about:blank url.

BUG=

Committed: https://crrev.com/5e894c11663cde3d8b9c65691ebf10983fc2a713
Cr-Commit-Position: refs/heads/master@{#427292}

[alshabalin, 2016-10-21 19:48:40]

Description was changed from

==========
Initialize all fields in WebsiteSettings.

show_ssl_decision_revoke_button_ field was never assigned when
constructing WebsiteSettings with about:blank url.

BUG=
==========

to

==========
Initialize all fields in WebsiteSettings.

show_ssl_decision_revoke_button_ field was never assigned when
constructing WebsiteSettings with about:blank url.

BUG=
==========

[alshabalin, 2016-10-21 19:48:40]

alshabalin@yandex-team.ru changed reviewers:
+ raymes@chromium.org

[alshabalin, 2016-10-21 19:57:13]

Also rewrote using non-static class member initializers (see
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/BrOCGoGXQpY
for the most recent discussion) to help with avoiding similar bugs in the
future. If you disagree with this approach, I'll move them back to the member
initializer list.

PTAL

[raymes, 2016-10-24 01:46:28]

Thanks for this.

https://codereview.chromium.org/2440183002/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/website_settings.cc (left):

https://codereview.chromium.org/2440183002/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.cc:270:
did_revoke_user_ssl_decisions_(false),
I realize there is no clear rules in the style guide, but I think for
consistency with other code we should keep these things in the initializer list
for now.

[alshabalin, 2016-10-24 08:33:42]

The CQ bit was checked by alshabalin@yandex-team.ru

[alshabalin, 2016-10-24 08:33:49]

https://codereview.chromium.org/2440183002/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/website_settings.cc (left):

https://codereview.chromium.org/2440183002/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.cc:270:
did_revoke_user_ssl_decisions_(false),
On 2016/10/24 01:46:27, raymes wrote:
> I realize there is no clear rules in the style guide, but I think for
> consistency with other code we should keep these things in the initializer
list
> for now.

Done.

[commit-bot: I haz the power, 2016-10-24 08:33:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 08:33:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 08:33:59]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[raymes, 2016-10-25 01:56:49]

lgtm thanks

[alshabalin, 2016-10-25 05:56:34]

The CQ bit was checked by alshabalin@yandex-team.ru

[commit-bot: I haz the power, 2016-10-25 05:56:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 06:48:09]

Description was changed from

==========
Initialize all fields in WebsiteSettings.

show_ssl_decision_revoke_button_ field was never assigned when
constructing WebsiteSettings with about:blank url.

BUG=
==========

to

==========
Initialize all fields in WebsiteSettings.

show_ssl_decision_revoke_button_ field was never assigned when
constructing WebsiteSettings with about:blank url.

BUG=
==========

[commit-bot: I haz the power, 2016-10-25 06:48:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-25 06:51:46]

Description was changed from

==========
Initialize all fields in WebsiteSettings.

show_ssl_decision_revoke_button_ field was never assigned when
constructing WebsiteSettings with about:blank url.

BUG=
==========

to

==========
Initialize all fields in WebsiteSettings.

show_ssl_decision_revoke_button_ field was never assigned when
constructing WebsiteSettings with about:blank url.

BUG=

Committed: https://crrev.com/5e894c11663cde3d8b9c65691ebf10983fc2a713
Cr-Commit-Position: refs/heads/master@{#427292}
==========

[commit-bot: I haz the power, 2016-10-25 06:51:47]

Patchset 2 (id:??) landed as
https://crrev.com/5e894c11663cde3d8b9c65691ebf10983fc2a713
Cr-Commit-Position: refs/heads/master@{#427292}