Initialize all fields in WebsiteSettings.

chrome/browser/ui/website_settings/website_settings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/website_settings/website_settings.h"
 
 #include <openssl/ssl.h>
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 242 matching lines @@
     WebsiteSettingsUI* ui,
     Profile* profile,
     TabSpecificContentSettings* tab_specific_content_settings,
     content::WebContents* web_contents,
     const GURL& url,
     const SecurityStateModel::SecurityInfo& security_info)
     : TabSpecificContentSettings::SiteDataObserver(
           tab_specific_content_settings),
       content::WebContentsObserver(web_contents),
       ui_(ui),
-      show_info_bar_(false),
       site_url_(url),
-      site_identity_status_(SITE_IDENTITY_STATUS_UNKNOWN),
-      site_connection_status_(SITE_CONNECTION_STATUS_UNKNOWN),
       content_settings_(HostContentSettingsMapFactory::GetForProfile(profile)),
       chrome_ssl_host_state_delegate_(
           ChromeSSLHostStateDelegateFactory::GetForProfile(profile)),
-      did_revoke_user_ssl_decisions_(false),

[raymes, 2016/10/24 01:46:27]

I realize there is no clear rules in the style guide, but I think for
consistency with other code we should keep these things in the initializer list
for now.

[alshabalin, 2016/10/24 08:33:49]

Done.

       profile_(profile) {
   Init(url, security_info);
 
   PresentSitePermissions();
   PresentSiteData();
   PresentSiteIdentity();
 
   // Every time the Website Settings UI is opened a |WebsiteSettings| object is
   // created. So this counts how ofter the Website Settings UI is opened.
   RecordWebsiteSettingsAction(WEBSITE_SETTINGS_OPENED);
@@ skipping 539 matching lines @@
   info.connection_status = site_connection_status_;
   info.connection_status_description =
       UTF16ToUTF8(site_connection_details_);
   info.identity_status = site_identity_status_;
   info.identity_status_description =
       UTF16ToUTF8(site_identity_details_);
   info.certificate = certificate_;
   info.show_ssl_decision_revoke_button = show_ssl_decision_revoke_button_;
   ui_->SetIdentityInfo(info);
 }