Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2440143003: Fix some lurking div by 0s in safe_math_impl.h (Closed)

Created:
4 years, 2 months ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
jschuh
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some lurking div by 0s in safe_math_impl.h Committed: https://crrev.com/dfd77a987650965071d0fddfbe0b806ce62ba337 Cr-Commit-Position: refs/heads/master@{#429385}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M base/numerics/safe_math_impl.h View 1 2 chunks +8 lines, -3 lines 0 comments Download
M base/numerics/safe_numerics_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Tom Sepez
Justin, for review.
4 years, 2 months ago (2016-10-21 18:32:31 UTC) #3
jschuh
lgtm modulo moving the CheckedMul change out to another CL. https://codereview.chromium.org/2440143003/diff/1/base/numerics/safe_math_impl.h File base/numerics/safe_math_impl.h (right): https://codereview.chromium.org/2440143003/diff/1/base/numerics/safe_math_impl.h#newcode225 ...
4 years, 1 month ago (2016-11-01 17:21:55 UTC) #7
Tom Sepez
On 2016/11/01 17:21:55, jschuh (very slow) wrote: > lgtm modulo moving the CheckedMul change out ...
4 years, 1 month ago (2016-11-01 17:52:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440143003/20001
4 years, 1 month ago (2016-11-01 20:00:56 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/156077)
4 years, 1 month ago (2016-11-01 23:57:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440143003/20001
4 years, 1 month ago (2016-11-02 17:00:01 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-02 20:18:31 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 20:20:21 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dfd77a987650965071d0fddfbe0b806ce62ba337
Cr-Commit-Position: refs/heads/master@{#429385}

Powered by Google App Engine
This is Rietveld 408576698