Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issue 244013002: Non-SFI NaCl: Disallow epoll family and allow poll instead (Closed)

Created:
6 years, 8 months ago by hamaji
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Non-SFI NaCl: Disallow epoll family and allow poll instead libevent tries to use epoll_create, but if it fails, it gracefully falls back to poll and will not call other epoll APIs. So, we return EPERM from epoll_create, allow poll, and disallow epoll_ctl and epoll_wait. TEST=out/Release/nacl_loader_unittests TEST=out/Release/browser_tests --gtest_filter='*NaCl*NonSfi*' TEST=trybots BUG=359285 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265866

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M components/nacl/loader/nonsfi/nonsfi_sandbox.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M components/nacl/loader/nonsfi/nonsfi_sandbox_sigsys_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/nacl/loader/nonsfi/nonsfi_sandbox_unittest.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hamaji
6 years, 8 months ago (2014-04-19 01:10:37 UTC) #1
Mark Seaborn
LGTM if tests pass OK. (Or is there a problem with tests as you mentioned ...
6 years, 8 months ago (2014-04-22 06:22:24 UTC) #2
Mark Seaborn
On 2014/04/22 06:22:24, Mark Seaborn wrote: > (Or is there a problem with tests as ...
6 years, 8 months ago (2014-04-22 06:23:06 UTC) #3
hamaji
On 2014/04/22 06:23:06, Mark Seaborn wrote: > On 2014/04/22 06:22:24, Mark Seaborn wrote: > > ...
6 years, 8 months ago (2014-04-23 10:40:56 UTC) #4
jln (very slow on Chromium)
On 2014/04/23 10:40:56, hamaji wrote: > On 2014/04/22 06:23:06, Mark Seaborn wrote: > > On ...
6 years, 8 months ago (2014-04-24 00:50:40 UTC) #5
hamaji
The CQ bit was checked by hamaji@chromium.org
6 years, 8 months ago (2014-04-24 02:06:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hamaji@chromium.org/244013002/1
6 years, 8 months ago (2014-04-24 02:41:37 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 05:46:20 UTC) #8
Message was sent while issue was closed.
Change committed as 265866

Powered by Google App Engine
This is Rietveld 408576698