Issue 2440123003: Fix Closure Compiler's compile.py error checking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2440123003: Fix Closure Compiler's compile.py error checking

Created:
4 years, 2 months ago by bhallam

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, dbeam+watch-closure_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix Closure Compiler's compile.py error checking This change matches compile.py error checking to match compile2.py. Without this change compile.py will fail when there are no errors. BUG=

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -10 lines)			Patch
M	third_party/closure_compiler/compile.py	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	third_party/closure_compiler/compile2.py	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	third_party/closure_compiler/compiler_test.py	View	1 chunk	+0 lines, -1 line	0 comments	Download