Fix Closure Compiler's compile.py error checking

third_party/closure_compiler/compile.py

 #!/usr/bin/python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs Closure compiler on JavaScript files to check for errors and produce
 minified output."""
 
 import argparse
 import os
@@ skipping 203 matching lines @@
     args += ["--%s" % arg for arg in closure_args]
 
     args_file_content = " %s" % " ".join(args)
     self._log_debug("Args: %s" % args_file_content.strip())
 
     args_file = self._create_temp_file(args_file_content)
     self._log_debug("Args file: %s" % args_file)
 
     processed_runner_args = ["--%s" % arg for arg in runner_args or []]
     processed_runner_args += ["--compiler-args-file=%s" % args_file]
-    _, stderr = self._run_jar(self._runner_jar, processed_runner_args)
+    return_code, stderr = self._run_jar(self._runner_jar, processed_runner_args)
 
     errors = stderr.strip().split("\n\n")
     maybe_summary = errors.pop()
 
-    if re.search(".*error.*warning.*typed", maybe_summary):
+    if return_code == 0:
       self._log_debug("Summary: %s" % maybe_summary)
     else:
-      # Not a summary. Running the jar failed. Bail.
+      # Running the jar failed.
       self._log_error(stderr)
       self._nuke_temp_files()
-      sys.exit(1)
 
     if errors and out_file:
       if os.path.exists(out_file):
         os.remove(out_file)
       if os.path.exists(self._MAP_FILE_FORMAT % out_file):
         os.remove(self._MAP_FILE_FORMAT % out_file)
 
     return errors, stderr
 
   def check(self, source_file, out_file=None, depends=None, externs=None,
@@ skipping 125 matching lines @@
   else:
     found_errors, stderr = checker.check_multiple(
         sources,
         out_file=opts.out_file,
         externs=externs,
         runner_args=opts.runner_args,
         closure_args=opts.closure_args)
     if found_errors:
       print stderr
       sys.exit(1)