bluetooth: bluez: GetName uses 'name' instead of 'alias'.

bluetooth: bluez: GetName uses 'name' instead of 'alias'.

BlueZ produces an 'alias' that includes the MAC address of
a remote device when the device name is unknown. Client
code of device/bluetooth must be able to detect an empty
name and also protect private information such as nearby
MAC addresses from being shared.

This patch changes our implementation to use the BlueZ
provided 'name' instead of 'alias'.

SimulateLowEnergyDvice(5) is implemented (crbug.com/622432)
to enable testing this change.

BUG=586438, 622432
Committed: https://crrev.com/667ebea934cb8baee8915753c4635bc88d8716ad
Cr-Commit-Position: refs/heads/master@{#430068}

[scheib, 2016-10-21 02:09:47]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 02:10:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scheib, 2016-10-21 03:20:16]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 03:20:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scheib, 2016-10-21 03:49:37]

Description was changed from

==========
bluetooth: bluez: GetName uses 'name' instead of 'alias'.

BlueZ produces an 'alias' that includes the MAC address of
a remote device when the device name is unknown. Client
code of device/bluetooth must be able to detect an empty
name and also protect private information such as nearby
MAC addresses from being shared.

This patch changes our implementation to use the BlueZ
provided 'name' instead of 'alias'.

BUG=586438
==========

to

==========
bluetooth: bluez: GetName uses 'name' instead of 'alias'.

BlueZ produces an 'alias' that includes the MAC address of
a remote device when the device name is unknown. Client
code of device/bluetooth must be able to detect an empty
name and also protect private information such as nearby
MAC addresses from being shared.

This patch changes our implementation to use the BlueZ
provided 'name' instead of 'alias'.

SimulateLowEnergyDvice(5) is implemented (crbug.com/622432)
to enable testing this change.

BUG=586438,622432
==========

[commit-bot: I haz the power, 2016-10-21 04:31:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 04:31:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scheib, 2016-10-21 05:54:22]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 05:54:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 06:45:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 06:45:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scheib, 2016-11-03 22:14:43]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 22:15:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 23:03:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 23:03:56]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[scheib, 2016-11-03 23:38:05]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[scheib, 2016-11-03 23:38:53]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-11-03 23:38:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scheib, 2016-11-03 23:39:00]

Patchset #1 (id:20001) has been deleted

[scheib, 2016-11-03 23:39:08]

Patchset #1 (id:40001) has been deleted

[scheib, 2016-11-03 23:39:18]

Patchset #1 (id:60001) has been deleted

[scheib, 2016-11-03 23:43:20]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[scheib, 2016-11-03 23:44:07]

Patchset #1 (id:80001) has been deleted

[commit-bot: I haz the power, 2016-11-03 23:44:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scheib, 2016-11-03 23:48:14]

scheib@chromium.org changed reviewers:
+ ortuno@chromium.org

[scheib, 2016-11-03 23:48:14]

PTAL

https://codereview.chromium.org/2440043002/diff/100001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_device_unittest.cc (left):

https://codereview.chromium.org/2440043002/diff/100001/device/bluetooth/bluet...
device/bluetooth/bluetooth_device_unittest.cc:684:
StartLowEnergyDiscoverySession();
StartLowEnergyDiscoverySession() is not needed for this test, and is not
implemented or trivial to implement on bluez.

[ortuno, 2016-11-04 00:05:04]

lgtm with a question.

https://codereview.chromium.org/2440043002/diff/100001/device/bluetooth/dbus/...
File device/bluetooth/dbus/fake_bluetooth_device_client.cc (right):

https://codereview.chromium.org/2440043002/diff/100001/device/bluetooth/dbus/...
device/bluetooth/dbus/fake_bluetooth_device_client.cc:1775:
name.value_or("Invalid Device Name set in "
Curious as to why you can't just DCHECK this.

[commit-bot: I haz the power, 2016-11-04 00:07:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 00:07:26]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[scheib, 2016-11-04 00:13:46]

Thanks. :( doh, looks like I still have a tryjob failure to dig into.

https://codereview.chromium.org/2440043002/diff/100001/device/bluetooth/dbus/...
File device/bluetooth/dbus/fake_bluetooth_device_client.cc (right):

https://codereview.chromium.org/2440043002/diff/100001/device/bluetooth/dbus/...
device/bluetooth/dbus/fake_bluetooth_device_client.cc:1775:
name.value_or("Invalid Device Name set in "
On 2016/11/04 00:05:04, ortuno wrote:
> Curious as to why you can't just DCHECK this.

We WANT to set it to an invalid state sometimes. The line below sets it as not
valid. However, the dbus properties in an invalid state still have values! So,
we set it intentionally to a bad value in case other code reads the value but
fails to check property->name.is_valid()

[ortuno, 2016-11-04 00:15:24]

Sadness. Seems like not starting a discovery session is giving some problems on
Android?

https://codereview.chromium.org/2440043002/diff/100001/device/bluetooth/dbus/...
File device/bluetooth/dbus/fake_bluetooth_device_client.cc (right):

https://codereview.chromium.org/2440043002/diff/100001/device/bluetooth/dbus/...
device/bluetooth/dbus/fake_bluetooth_device_client.cc:1775:
name.value_or("Invalid Device Name set in "
On 2016/11/04 at 00:13:46, scheib wrote:
> On 2016/11/04 00:05:04, ortuno wrote:
> > Curious as to why you can't just DCHECK this.
> 
> We WANT to set it to an invalid state sometimes. The line below sets it as not
valid. However, the dbus properties in an invalid state still have values! So,
we set it intentionally to a bad value in case other code reads the value but
fails to check property->name.is_valid()

I see. Thanks.

[scheib, 2016-11-04 20:54:08]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 20:54:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scheib, 2016-11-04 20:56:04]

scheib@chromium.org changed reviewers:
+ stevenjb@chromium.org

[scheib, 2016-11-04 20:56:05]

stevenjb PTAL as OWNER:
chrome/browser/ui/webui/options/chromeos/bluetooth_options_browsertest.js

[stevenjb, 2016-11-04 21:01:44]

rs lgtm

[scheib, 2016-11-04 22:11:52]

The CQ bit was unchecked by scheib@chromium.org

[scheib, 2016-11-04 22:11:53]

The CQ bit was checked by scheib@chromium.org

[scheib, 2016-11-04 22:11:53]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org
Link to the patchset: https://codereview.chromium.org/2440043002/#ps120001
(title: "Android needs StartLowEnergyDiscoverySession; Browser test needs
s/alias/name/")

[commit-bot: I haz the power, 2016-11-04 22:12:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 00:06:35]

Description was changed from

==========
bluetooth: bluez: GetName uses 'name' instead of 'alias'.

BlueZ produces an 'alias' that includes the MAC address of
a remote device when the device name is unknown. Client
code of device/bluetooth must be able to detect an empty
name and also protect private information such as nearby
MAC addresses from being shared.

This patch changes our implementation to use the BlueZ
provided 'name' instead of 'alias'.

SimulateLowEnergyDvice(5) is implemented (crbug.com/622432)
to enable testing this change.

BUG=586438,622432
==========

to

==========
bluetooth: bluez: GetName uses 'name' instead of 'alias'.

BlueZ produces an 'alias' that includes the MAC address of
a remote device when the device name is unknown. Client
code of device/bluetooth must be able to detect an empty
name and also protect private information such as nearby
MAC addresses from being shared.

This patch changes our implementation to use the BlueZ
provided 'name' instead of 'alias'.

SimulateLowEnergyDvice(5) is implemented (crbug.com/622432)
to enable testing this change.

BUG=586438,622432
==========

[commit-bot: I haz the power, 2016-11-05 00:06:36]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2016-11-05 00:10:38]

Description was changed from

==========
bluetooth: bluez: GetName uses 'name' instead of 'alias'.

BlueZ produces an 'alias' that includes the MAC address of
a remote device when the device name is unknown. Client
code of device/bluetooth must be able to detect an empty
name and also protect private information such as nearby
MAC addresses from being shared.

This patch changes our implementation to use the BlueZ
provided 'name' instead of 'alias'.

SimulateLowEnergyDvice(5) is implemented (crbug.com/622432)
to enable testing this change.

BUG=586438,622432
==========

to

==========
bluetooth: bluez: GetName uses 'name' instead of 'alias'.

BlueZ produces an 'alias' that includes the MAC address of
a remote device when the device name is unknown. Client
code of device/bluetooth must be able to detect an empty
name and also protect private information such as nearby
MAC addresses from being shared.

This patch changes our implementation to use the BlueZ
provided 'name' instead of 'alias'.

SimulateLowEnergyDvice(5) is implemented (crbug.com/622432)
to enable testing this change.

BUG=586438,622432

Committed: https://crrev.com/667ebea934cb8baee8915753c4635bc88d8716ad
Cr-Commit-Position: refs/heads/master@{#430068}
==========

[commit-bot: I haz the power, 2016-11-05 00:10:39]

Patchset 2 (id:??) landed as
https://crrev.com/667ebea934cb8baee8915753c4635bc88d8716ad
Cr-Commit-Position: refs/heads/master@{#430068}