device/bluetooth/dbus/fake_bluetooth_device_client.h - Issue 2440043002: bluetooth: bluez: GetName uses 'name' instead of 'alias'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/dbus/fake_bluetooth_device_client.h

Issue 2440043002: bluetooth: bluez: GetName uses 'name' instead of 'alias'. (Closed)

Patch Set: Android needs StartLowEnergyDiscoverySession; Browser test needs s/alias/name/ Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/bluetooth/dbus/fake_bluetooth_device_client.h

diff --git a/device/bluetooth/dbus/fake_bluetooth_device_client.h b/device/bluetooth/dbus/fake_bluetooth_device_client.h

index d939e1156fd33dab88556f80c82e36489ba03e14..9a7d67268783683d55c9b7728edeaa4c3b07d515 100644

--- a/device/bluetooth/dbus/fake_bluetooth_device_client.h

+++ b/device/bluetooth/dbus/fake_bluetooth_device_client.h

@@ -13,6 +13,7 @@

#include "base/bind.h"

#include "base/callback.h"

#include "base/observer_list.h"

+#include "base/optional.h"

#include "dbus/object_path.h"

#include "dbus/property.h"

#include "device/bluetooth/bluetooth_common.h"

@@ -156,7 +157,7 @@ class DEVICE_BLUETOOTH_EXPORT FakeBluetoothDeviceClient

// Create a test Bluetooth device with the given properties.

void CreateTestDevice(const dbus::ObjectPath& adapter_path,

- const std::string name,

+ const base::Optional<std::string> name,

const std::string alias,

const std::string device_address,

const std::vector<std::string>& service_uuids,