Add threadsafe version of PermissionManager::GetPermissionStatus

Add threadsafe version of PermissionManager::GetPermissionStatus

Add a version of GetPermissionStatus that takes a host_content_settings_map.
This method is guaranteed to be threadsafe.

BUG=658020
R=jochen, mlamouri

Committed: https://crrev.com/d6b19d48cf91f89c1ec414485b781f2ef2434521
Cr-Commit-Position: refs/heads/master@{#427078}

[dougt, 2016-10-20 21:47:37]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 21:48:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dougt, 2016-10-20 22:27:14]

Description was changed from

==========
Add threadsafe version of PermissionManager::GetPermissionStatus

Add a version of GetPermissionStatus that takes a host_content_settings_map.
This method is guaranteed to be threadsafe.

BUG=658020

R=jochen

Add DCHECKs for thread access PermissionManager.

The PermissionManager is not thread safe. Lets add some DCHECKs to
let us know when there is an unsafe access.

BUG=658018

R=jochen
==========

to

==========
Add threadsafe version of PermissionManager::GetPermissionStatus

Add a version of GetPermissionStatus that takes a host_content_settings_map.
This method is guaranteed to be threadsafe.

BUG=658020

R=jochen
==========

[dougt, 2016-10-20 22:32:16]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 22:32:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 22:55:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 22:55:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dougt, 2016-10-21 17:05:00]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 17:05:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-10-21 17:52:47]

lgtm

[commit-bot: I haz the power, 2016-10-21 20:04:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 20:04:39]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2016-10-22 11:36:38]

mlamouri@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-10-22 11:36:38]

Can you add unit tests? It shouldn't be very painful because there are already
some :)

Also, I understand the theoretical need for this but in practice, do we have
consumers?

https://codereview.chromium.org/2439673004/diff/40001/chrome/browser/permissi...
File chrome/browser/permissions/permission_context_base.cc (right):

https://codereview.chromium.org/2439673004/diff/40001/chrome/browser/permissi...
chrome/browser/permissions/permission_context_base.cc:144:
HostContentSettingsMap* host =
If that method needs to be called from the UI thread, maybe add a DCHECK?

https://codereview.chromium.org/2439673004/diff/40001/chrome/browser/permissi...
File chrome/browser/permissions/permission_context_base.h (right):

https://codereview.chromium.org/2439673004/diff/40001/chrome/browser/permissi...
chrome/browser/permissions/permission_context_base.h:100: // Withdraw an
existing permission reqUest, no op if the permission request
typo: s/reqUest/request/

[dougt, 2016-10-23 08:06:48]

np. I'll test that GetPermissionStatus can be used from a non-main thread.


> Also, I understand the theoretical need for this but in practice, do we have
> consumers?

See https://codereview.chromium.org/2441083002/

The storage policy code now calls into GetPermissionStatus from a non-main
thread.
in_reply_to: 5718998062727168
subject: Add threadsafe version of PermissionManager::GetPermissionStatus

[dougt, 2016-10-23 08:06:49]

np. I'll test that GetPermissionStatus can be used from a non-main thread.


> Also, I understand the theoretical need for this but in practice, do we have
> consumers?

See https://codereview.chromium.org/2441083002/

The storage policy code now calls into GetPermissionStatus from a non-main
thread.
in_reply_to: 5718998062727168
subject: Add threadsafe version of PermissionManager::GetPermissionStatus

[dougt, 2016-10-23 08:14:39]

Description was changed from

==========
Add threadsafe version of PermissionManager::GetPermissionStatus

Add a version of GetPermissionStatus that takes a host_content_settings_map.
This method is guaranteed to be threadsafe.

BUG=658020

R=jochen
==========

to

==========
Add threadsafe version of PermissionManager::GetPermissionStatus

Add a version of GetPermissionStatus that takes a host_content_settings_map.
This method is guaranteed to be threadsafe.

BUG=658020

R=jochen, mlamouri
==========

[dougt, 2016-10-23 08:15:03]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-23 08:15:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-23 09:23:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-23 09:23:57]

Dry run: This issue passed the CQ dry run.

[dougt, 2016-10-23 19:42:07]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-23 19:42:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-23 20:52:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-23 20:52:33]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2016-10-24 10:40:51]

https://codereview.chromium.org/2439673004/diff/80001/chrome/browser/permissi...
File chrome/browser/permissions/permission_manager_unittest.cc (right):

https://codereview.chromium.org/2439673004/diff/80001/chrome/browser/permissi...
chrome/browser/permissions/permission_manager_unittest.cc:135: run_loop.Run();
Looks fine but I would have done this a bit differently:
- one test checking that calling the regular GetPermissionStatus on DEBUG will
crash
- one test checking that calling the GetPermissionStatus will
HostContentSettingsMap returns the correct value (and doesn't crash ;))

I'm not super comfortable with the magic thread-check in the test.

However, lgtm either way :)

[dougt, 2016-10-24 15:39:49]

The CQ bit was checked by dougt@chromium.org

[dougt, 2016-10-24 15:39:49]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2439673004/#ps80001
(title: "Use thread_bundle_ REAL_IO_THREAD to ensure multi-thread testing")

[commit-bot: I haz the power, 2016-10-24 15:40:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 15:53:09]

Description was changed from

==========
Add threadsafe version of PermissionManager::GetPermissionStatus

Add a version of GetPermissionStatus that takes a host_content_settings_map.
This method is guaranteed to be threadsafe.

BUG=658020

R=jochen, mlamouri
==========

to

==========
Add threadsafe version of PermissionManager::GetPermissionStatus

Add a version of GetPermissionStatus that takes a host_content_settings_map.
This method is guaranteed to be threadsafe.

BUG=658020

R=jochen, mlamouri
==========

[commit-bot: I haz the power, 2016-10-24 15:53:10]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-24 16:19:19]

Description was changed from

==========
Add threadsafe version of PermissionManager::GetPermissionStatus

Add a version of GetPermissionStatus that takes a host_content_settings_map.
This method is guaranteed to be threadsafe.

BUG=658020

R=jochen, mlamouri
==========

to

==========
Add threadsafe version of PermissionManager::GetPermissionStatus

Add a version of GetPermissionStatus that takes a host_content_settings_map.
This method is guaranteed to be threadsafe.

BUG=658020

R=jochen, mlamouri

Committed: https://crrev.com/d6b19d48cf91f89c1ec414485b781f2ef2434521
Cr-Commit-Position: refs/heads/master@{#427078}
==========

[commit-bot: I haz the power, 2016-10-24 16:19:20]

Patchset 5 (id:??) landed as
https://crrev.com/d6b19d48cf91f89c1ec414485b781f2ef2434521
Cr-Commit-Position: refs/heads/master@{#427078}

[dougt, 2016-10-25 00:06:38]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2446863002/ by dougt@chromium.org.

The reason for reverting is: Going to address a number of issues that Raymes
pointed out including:

1) It's unclear the purpose the overloaded GetPermissionStatus function (see
https://google.github.io/styleguide/cppguide.html#Function_Overloading). It
could be good to name it something that reflects its usage from a background
thread.

2) In PermissionManager, it's unclear that it is threadsafe while the rest of
the class isn't - we should add a comment.

3) It's unclear why HostContentSettingsMap needs to be passed in - it's already
available in the PermissionContextBase.

4) I feel like it would be better to leave the default implementation empty in
the PermissionContextBase and have NOTREACHED. Then if someone really wants to
support querying a permission safely from a background thread, they have to
think about it.

.

[dougt, 2017-01-15 04:41:44]

Description was changed from

==========
Add threadsafe version of PermissionManager::GetPermissionStatus

Add a version of GetPermissionStatus that takes a host_content_settings_map.
This method is guaranteed to be threadsafe.

BUG=658020

R=jochen, mlamouri

Committed: https://crrev.com/d6b19d48cf91f89c1ec414485b781f2ef2434521
Cr-Commit-Position: refs/heads/master@{#427078}
==========

to

==========
Add threadsafe version of PermissionManager::GetPermissionStatus

Add a version of GetPermissionStatus that takes a host_content_settings_map.
This method is guaranteed to be threadsafe.

BUG=658020

R=jochen, mlamouri

Committed: https://crrev.com/d6b19d48cf91f89c1ec414485b781f2ef2434521
Cr-Commit-Position: refs/heads/master@{#427078}
==========