Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5908)

Unified Diff: chrome/browser/permissions/permission_context_base.h

Issue 2439673004: Add threadsafe version of PermissionManager::GetPermissionStatus (Closed)
Patch Set: Use thread_bundle_ REAL_IO_THREAD to ensure multi-thread testing Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_context_base.h
diff --git a/chrome/browser/permissions/permission_context_base.h b/chrome/browser/permissions/permission_context_base.h
index f556165e1334adbf2f4f866fe7c3528a137b98cc..ee7a727a7c04b48312f17c6dcb11adc978b5d6d3 100644
--- a/chrome/browser/permissions/permission_context_base.h
+++ b/chrome/browser/permissions/permission_context_base.h
@@ -21,6 +21,7 @@
class PermissionQueueController;
#endif
class GURL;
+class HostContentSettingsMap;
class PermissionRequestID;
class Profile;
@@ -85,6 +86,13 @@ class PermissionContextBase : public KeyedService {
const GURL& requesting_origin,
const GURL& embedding_origin) const;
+ // Thread safe version of GetPermissionStatus for consumers that already have
+ // an associated HostContentSettingsMap.
+ virtual ContentSetting GetPermissionStatus(
+ HostContentSettingsMap* host,
+ const GURL& requesting_origin,
+ const GURL& embedding_origin) const;
+
// Resets the permission to its default value.
virtual void ResetPermission(const GURL& requesting_origin,
const GURL& embedding_origin);
@@ -148,6 +156,7 @@ class PermissionContextBase : public KeyedService {
ContentSetting content_setting);
// Whether the permission should be restricted to secure origins.
+ // Note: Maybe be called from multiple threads.
virtual bool IsRestrictedToSecureOrigins() const = 0;
content::PermissionType permission_type() const { return permission_type_; }

Powered by Google App Engine
This is Rietveld 408576698