Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2439573003: Experiment with new function-type syntax.

Created:
4 years, 2 months ago by floitsch
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Experiment with new function-type syntax.

Patch Set 1 #

Patch Set 2 : Change a few more typedefs. #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -74 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 7 chunks +111 lines, -2 lines 4 comments Download
M pkg/compiler/lib/compiler.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/common.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/dart_types.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/invariant.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/helpers/helpers.dart View 1 2 chunks +5 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/helpers/trace.dart View 1 4 chunks +11 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/declarations.dart View 1 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 3 chunks +7 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel.dart View 1 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Lasse Reichstein Nielsen
https://codereview.chromium.org/2439573003/diff/20001/pkg/analyzer/lib/src/generated/parser.dart File pkg/analyzer/lib/src/generated/parser.dart (right): https://codereview.chromium.org/2439573003/diff/20001/pkg/analyzer/lib/src/generated/parser.dart#newcode4838 pkg/analyzer/lib/src/generated/parser.dart:4838: * functionType ::= typeParameterList? formalParameterList '-' '>' returnType I ...
4 years, 2 months ago (2016-10-20 19:36:44 UTC) #2
floitsch
4 years, 2 months ago (2016-10-21 12:24:34 UTC) #3 
https://codereview.chromium.org/2439573003/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/parser.dart (right):

https://codereview.chromium.org/2439573003/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/parser.dart:4838: *     functionType ::=
typeParameterList? formalParameterList '-' '>' returnType
On 2016/10/20 19:36:44, Lasse Reichstein Nielsen wrote:
> I assume you use '-' '>' instead of '->' because it's easier than introducing
a
> new token?

correct.

https://codereview.chromium.org/2439573003/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/parser.dart:6585: parameters =
_parseFormalParameterListUnchecked();
On 2016/10/20 19:36:44, Lasse Reichstein Nielsen wrote:
> Using the old formal-parameter list, so a single identifier is a name, not a
> type, right?

Right.

I wanted to see how hard it would be to change the parser. Resolving it the
right way shouldn't be too hard, once the parser has constructed the nodes.

Powered by Google App Engine
This is Rietveld 408576698