Do not use overlays when VR shell is enabled.

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 2839 matching lines @@
 #endif
 
   if (!url_index_.get() || url_index_->frame() != frame_)
     url_index_.reset(new media::UrlIndex(frame_));
 
   media::WebMediaPlayerImpl* media_player = new media::WebMediaPlayerImpl(
       frame_, client, encrypted_client,
       GetWebMediaPlayerDelegate()->AsWeakPtr(),
       std::move(media_renderer_factory), url_index_, params);
 
+
+  // TODO(crbug/673886): Re-enable overlays with VR shell enabled when VR

[ddorwin, 2016/12/15 01:23:52]

crbug.com so it is clickable.

[amp, 2016/12/15 21:49:02]

Done.

+  // shell's video reprojection surface is enabled.
+  media_player->SetEnableFullscreenOverlays(

[ddorwin, 2016/12/15 01:23:52]

This forcibly overrides the current (default) setting and potentially future
changes (none exist at the moment) regardless of the VrShell flag.

To fix this, we need to Set(false) iff VrShell is enabled.

However, such subtleties are a good argument for having all the logic for this
setting in exactly one place. That would also make it clear that we need to
correctly handle the feature flag metrics.

[amp, 2016/12/15 21:49:02]

Ok.  I'll pull back out the overlay feature check here and do the logic for
making sure we have the right value being passed into the setter.

I'll also update the TODO that we should remove this after vr shell is fixed and
move the overlay feature check back into constructor (per an ealier comment form
liberato@).

+      !base::FeatureList::IsEnabled(features::kVrShell));
+
 #if defined(OS_ANDROID)  // WMPI_CAST
   media_player->SetMediaPlayerManager(GetMediaPlayerManager());
   media_player->SetDeviceScaleFactor(render_view_->GetDeviceScaleFactor());
   media_player->SetUseFallbackPath(use_fallback_path);
 #endif  // defined(OS_ANDROID)
 
 #if BUILDFLAG(ENABLE_MEDIA_REMOTING)
   remoting_controller_ptr->SetSwitchRendererCallback(base::Bind(
       &media::WebMediaPlayerImpl::ScheduleRestart, media_player->AsWeakPtr()));
 #endif
@@ skipping 3806 matching lines @@
   // event target. Potentially a Pepper plugin will receive the event.
   // In order to tell whether a plugin gets the last mouse event and which it
   // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets
   // the event, it will notify us via DidReceiveMouseEvent() and set itself as
   // |pepper_last_mouse_event_target_|.
   pepper_last_mouse_event_target_ = nullptr;
 #endif
 }
 
 }  // namespace content