Do not use overlays when VR shell is enabled.

media/blink/webmediaplayer_impl.h

Index: media/blink/webmediaplayer_impl.h
diff --git a/media/blink/webmediaplayer_impl.h b/media/blink/webmediaplayer_impl.h
index 6e01840d71c6e0e05129c139d91354fd04f2f4d9..45f2a92457a516b93cdb5c17fcf3d568fae5d7e6 100644
--- a/media/blink/webmediaplayer_impl.h
+++ b/media/blink/webmediaplayer_impl.h
@@ -207,6 +207,7 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
                                     PipelineStatus status);
   gfx::Size GetCanvasSize() const;
   void SetDeviceScaleFactor(float scale_factor);
+  void SetEnableFullscreenOverlays(bool disable_overlays);

[mthiesse, 2016/12/14 16:08:19]

Does it makes sense to have a function for this? Looks like it's only ever set
once on creation, so maybe it should be part of the constructor?

[amp, 2016/12/14 18:15:04]

After the inversion and pulling out the other feature check it never changes so
it could work in the constructor.

@liberato, WDYT?

[liberato (no reviews please), 2016/12/14 19:39:07]

i find adding booleans in the constructor to be error-prone.  since we already
have plenty of setters that are used in render_frame_impl, i'd prefer to keep
this explicit too.

to be honest, i preferred when WMPI figured it out for itself.  Once we remove
this flag for VR, we'll probably want to put it back that way.

also, you've got |disable_overlays| instead of |enable_overlays| here.

[amp, 2016/12/14 22:02:09]

Done.  Going with a setter in latest patch.

   void setPoster(const blink::WebURL& poster) override;
   void SetUseFallbackPath(bool use_fallback_path);
 #endif
@@ -535,9 +536,9 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
   // Force to use SurfaceView instead of SurfaceTexture on Android.
   bool force_video_overlays_;
 
-  // Prevent use of SurfaceView on Android. (Ignored when
+  // Allow use of SurfaceView on Android. (Ignored when
   // |force_video_overlays_| is true.)
-  bool disable_fullscreen_video_overlays_;
+  bool enable_fullscreen_video_overlays_;
 
   // Suppresses calls to OnPipelineError() after destruction / shutdown has been
   // started; prevents us from spuriously logging errors that are transient or