Do not use overlays when VR shell is enabled.

content/renderer/render_frame_impl.cc

Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 5007f28f5c19f40d05bae2cdb26a00a3940ca5de..72159e7d3638be39ad4a308749042b112e18c794 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2860,6 +2860,12 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
       GetWebMediaPlayerDelegate()->AsWeakPtr(),
       std::move(media_renderer_factory), url_index_, params);
 
+  // TODO(crbug/673886): Enable overlays for VR shell when video reprojection

[mthiesse, 2016/12/14 16:08:19]

For clarity, how about: Re-enable overlays with VR Shell enabled when VR Shell's
video reprojection surface is enabled.

[amp, 2016/12/14 18:15:04]

Sounds good. I was trying to find a good way to word it and coming up short.

Done.

[liberato (no reviews please), 2016/12/14 19:39:06]

please also include in the TODO (or the bug) to move the kOverlayFullscreenVideo
check back into the constructor, and remove SetEnableFullscreenOverlays
entirely.  it's less burden on whoever instantiates WMPI, since it's an
implementation detail.  it's only exposed because getting the VR state into WMPI
directly turned out to be even worse.

[amp, 2016/12/14 22:02:09]

I moved the kOverlayFullscreenVideo back into the constructor.  I don't think
there is a strong reason to pull it out now if we are just going to put it back
later.

+  // surface is enabled.
+  media_player->SetEnableFullscreenOverlays(
+      base::FeatureList::IsEnabled(media::kOverlayFullscreenVideo) &&
+      !base::FeatureList::IsEnabled(features::kVrShell));
+
 #if defined(OS_ANDROID)  // WMPI_CAST
   media_player->SetMediaPlayerManager(GetMediaPlayerManager());
   media_player->SetDeviceScaleFactor(render_view_->GetDeviceScaleFactor());