Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 24395004: Merge 157914 "Prevent crash due to XMLDocumentParser destruction" (Closed)

Created:
7 years, 3 months ago by kareng
Modified:
7 years, 3 months ago
Reviewers:
pdr.
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Merge 157914 "Prevent crash due to XMLDocumentParser destruction" > Prevent crash due to XMLDocumentParser destruction > > This patch prevents a crash in XMLDocumentParser::append due to the > parser being destructed through doWrite. Destructing the parser can > lead to the subsequent isStopped() check to fail to return, but by > keeping the parser alive we ensure isStopped() correctly exits. > > BUG=278908 > > Review URL: https://chromiumcodereview.appspot.com/23456031 TBR=pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kareng
7 years, 3 months ago (2013-09-23 20:35:02 UTC) #1
kareng
7 years, 3 months ago (2013-09-23 20:35:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r158204.

Powered by Google App Engine
This is Rietveld 408576698