Source/core/xml/parser/XMLDocumentParser.cpp - Issue 24395004: Merge 157914 "Prevent crash due to XMLDocumentParser destruction"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/parser/XMLDocumentParser.cpp

Issue 24395004: Merge 157914 "Prevent crash due to XMLDocumentParser destruction" (Closed) Base URL: svn://svn.chromium.org/blink/branches/chromium/1599/

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/xml/parser/XMLDocumentParser.cpp

===================================================================

--- Source/core/xml/parser/XMLDocumentParser.cpp (revision 158203)

+++ Source/core/xml/parser/XMLDocumentParser.cpp (working copy)

@@ -349,6 +349,10 @@

return;

}

+ // JavaScript can detach the parser. Make sure this is not released

+ // before the end of this method.

+ RefPtr<XMLDocumentParser> protect(this);

doWrite(source.toString());

if (isStopped())

« no previous file with comments | « no previous file | no next file » | no next file with comments »