Simplifiying the firstInFlowChildBox function

Simplifiying the firstInFlowChildBox function

Since we use nextInFlowChildBox we don't need to iterate over the
children, looking for the first in-flow child.

Committed: https://crrev.com/8831772546aac12d625412f9e24c99c7c3c1a411
Cr-Commit-Position: refs/heads/master@{#426165}

[jfernandez, 2016-10-19 11:46:00]

jfernandez@igalia.com changed reviewers:
+ cbiesinger@chromium.org, rego@igalia.com, svillar@igalia.com

[Manuel Rego, 2016-10-19 11:49:55]

https://codereview.chromium.org/2439483002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBox.h (right):

https://codereview.chromium.org/2439483002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBox.h:1582: :
first->nextInFlowSiblingBox();
Don't you need to check if first is not null?
What happens if you call this in a box without children?

[Manuel Rego, 2016-10-19 11:58:50]

lgtm

Now better, thanks.

[jfernandez, 2016-10-19 12:00:58]

The CQ bit was checked by jfernandez@igalia.com

[commit-bot: I haz the power, 2016-10-19 12:01:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 13:00:38]

Committed patchset #2 (id:20001)

[cbiesinger, 2016-10-19 18:31:40]

lgtm

[commit-bot: I haz the power, 2016-10-21 13:07:32]

Description was changed from

==========
Simplifiying the firstInFlowChildBox function

Since we use nextInFlowChildBox we don't need to iterate over the
children, looking for the first in-flow child.
==========

to

==========
Simplifiying the firstInFlowChildBox function

Since we use nextInFlowChildBox we don't need to iterate over the
children, looking for the first in-flow child.

Committed: https://crrev.com/8831772546aac12d625412f9e24c99c7c3c1a411
Cr-Commit-Position: refs/heads/master@{#426165}
==========

[commit-bot: I haz the power, 2016-10-21 13:07:32]

Patchset 2 (id:??) landed as
https://crrev.com/8831772546aac12d625412f9e24c99c7c3c1a411
Cr-Commit-Position: refs/heads/master@{#426165}