Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: chrome/browser/ui/views/chooser_content_view_unittest.cc

Issue 2439453006: Make "to allow pairing" not be a link in the WebBluetooth chooser (Closed)
Patch Set: make "to allow pairing" not be a link in the WebBluetooth chooser Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/chooser_content_view.h" 5 #include "chrome/browser/ui/views/chooser_content_view.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 ASSERT_TRUE(table_view_); 53 ASSERT_TRUE(table_view_);
54 table_model_ = table_view_->model(); 54 table_model_ = table_view_->model();
55 ASSERT_TRUE(table_model_); 55 ASSERT_TRUE(table_model_);
56 throbber_ = chooser_content_view_->throbber_for_test(); 56 throbber_ = chooser_content_view_->throbber_for_test();
57 ASSERT_TRUE(throbber_); 57 ASSERT_TRUE(throbber_);
58 turn_adapter_off_help_ = 58 turn_adapter_off_help_ =
59 chooser_content_view_->turn_adapter_off_help_for_test(); 59 chooser_content_view_->turn_adapter_off_help_for_test();
60 ASSERT_TRUE(turn_adapter_off_help_); 60 ASSERT_TRUE(turn_adapter_off_help_);
61 discovery_state_.reset(chooser_content_view_->CreateExtraView()); 61 discovery_state_.reset(chooser_content_view_->CreateExtraView());
62 ASSERT_TRUE(discovery_state_); 62 ASSERT_TRUE(discovery_state_);
63 styled_label_.reset(chooser_content_view_->CreateFootnoteView()); 63 help_link_.reset(chooser_content_view_->CreateFootnoteView());
64 ASSERT_TRUE(styled_label_); 64 ASSERT_TRUE(help_link_);
65 } 65 }
66 66
67 protected: 67 protected:
68 // |discovery_state_| needs to be valid when |chooser_content_view_| is 68 // |discovery_state_| needs to be valid when |chooser_content_view_| is
69 // released, since ChooserContentView's destructor needs to access it. 69 // released, since ChooserContentView's destructor needs to access it.
70 // So it is declared before |chooser_content_view_|. 70 // So it is declared before |chooser_content_view_|.
71 std::unique_ptr<views::Link> discovery_state_; 71 std::unique_ptr<views::Link> discovery_state_;
72 std::unique_ptr<MockTableViewObserver> mock_table_view_observer_; 72 std::unique_ptr<MockTableViewObserver> mock_table_view_observer_;
73 std::unique_ptr<ChooserContentView> chooser_content_view_; 73 std::unique_ptr<ChooserContentView> chooser_content_view_;
74 MockChooserController* mock_chooser_controller_; 74 MockChooserController* mock_chooser_controller_;
75 views::TableView* table_view_; 75 views::TableView* table_view_;
76 ui::TableModel* table_model_; 76 ui::TableModel* table_model_;
77 views::Throbber* throbber_; 77 views::Throbber* throbber_;
78 views::Link* turn_adapter_off_help_; 78 views::StyledLabel* turn_adapter_off_help_;
79 std::unique_ptr<views::StyledLabel> styled_label_; 79 std::unique_ptr<views::StyledLabel> help_link_;
80 80
81 private: 81 private:
82 DISALLOW_COPY_AND_ASSIGN(ChooserContentViewTest); 82 DISALLOW_COPY_AND_ASSIGN(ChooserContentViewTest);
83 }; 83 };
84 84
85 TEST_F(ChooserContentViewTest, InitialState) { 85 TEST_F(ChooserContentViewTest, InitialState) {
86 EXPECT_CALL(*mock_table_view_observer_, OnSelectionChanged()).Times(0); 86 EXPECT_CALL(*mock_table_view_observer_, OnSelectionChanged()).Times(0);
87 87
88 EXPECT_TRUE(table_view_->visible()); 88 EXPECT_TRUE(table_view_->visible());
89 // Since "No devices found." needs to be displayed on the |table_view_|, 89 // Since "No devices found." needs to be displayed on the |table_view_|,
(...skipping 421 matching lines...) Expand 10 before | Expand all | Expand 10 after
511 MockChooserController::ConnectedPairedStatus::NONE); 511 MockChooserController::ConnectedPairedStatus::NONE);
512 512
513 table_view_->Select(1); 513 table_view_->Select(1);
514 514
515 mock_chooser_controller_->OnAdapterPresenceChanged( 515 mock_chooser_controller_->OnAdapterPresenceChanged(
516 content::BluetoothChooser::AdapterPresence::POWERED_OFF); 516 content::BluetoothChooser::AdapterPresence::POWERED_OFF);
517 EXPECT_EQ(0u, mock_chooser_controller_->NumOptions()); 517 EXPECT_EQ(0u, mock_chooser_controller_->NumOptions());
518 EXPECT_FALSE(table_view_->visible()); 518 EXPECT_FALSE(table_view_->visible());
519 EXPECT_FALSE(throbber_->visible()); 519 EXPECT_FALSE(throbber_->visible());
520 EXPECT_TRUE(turn_adapter_off_help_->visible()); 520 EXPECT_TRUE(turn_adapter_off_help_->visible());
521 EXPECT_EQ(
522 l10n_util::GetStringUTF16(IDS_BLUETOOTH_DEVICE_CHOOSER_TURN_ADAPTER_OFF),
523 turn_adapter_off_help_->text());
524 EXPECT_FALSE(discovery_state_->enabled()); 521 EXPECT_FALSE(discovery_state_->enabled());
525 EXPECT_TRUE(discovery_state_->text().empty()); 522 EXPECT_TRUE(discovery_state_->text().empty());
526 523
527 mock_chooser_controller_->OnAdapterPresenceChanged( 524 mock_chooser_controller_->OnAdapterPresenceChanged(
528 content::BluetoothChooser::AdapterPresence::POWERED_ON); 525 content::BluetoothChooser::AdapterPresence::POWERED_ON);
529 EXPECT_EQ(0u, mock_chooser_controller_->NumOptions()); 526 EXPECT_EQ(0u, mock_chooser_controller_->NumOptions());
530 EXPECT_TRUE(table_view_->visible()); 527 EXPECT_TRUE(table_view_->visible());
531 EXPECT_EQ(1, table_view_->RowCount()); 528 EXPECT_EQ(1, table_view_->RowCount());
532 EXPECT_EQ( 529 EXPECT_EQ(
533 l10n_util::GetStringUTF16(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT), 530 l10n_util::GetStringUTF16(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT),
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
637 EXPECT_EQ(0, table_view_->FirstSelectedRow()); 634 EXPECT_EQ(0, table_view_->FirstSelectedRow());
638 EXPECT_FALSE(throbber_->visible()); 635 EXPECT_FALSE(throbber_->visible());
639 // |discovery_state_| is enabled and shows a link. 636 // |discovery_state_| is enabled and shows a link.
640 EXPECT_TRUE(discovery_state_->enabled()); 637 EXPECT_TRUE(discovery_state_->enabled());
641 EXPECT_EQ(l10n_util::GetStringUTF16(IDS_BLUETOOTH_DEVICE_CHOOSER_RE_SCAN), 638 EXPECT_EQ(l10n_util::GetStringUTF16(IDS_BLUETOOTH_DEVICE_CHOOSER_RE_SCAN),
642 discovery_state_->text()); 639 discovery_state_->text());
643 } 640 }
644 641
645 TEST_F(ChooserContentViewTest, ClickAdapterOffHelpLink) { 642 TEST_F(ChooserContentViewTest, ClickAdapterOffHelpLink) {
646 EXPECT_CALL(*mock_chooser_controller_, OpenAdapterOffHelpUrl()).Times(1); 643 EXPECT_CALL(*mock_chooser_controller_, OpenAdapterOffHelpUrl()).Times(1);
647 chooser_content_view_->LinkClicked(turn_adapter_off_help_, 0); 644 turn_adapter_off_help_->LinkClicked(nullptr, 0);
648 } 645 }
649 646
650 TEST_F(ChooserContentViewTest, ClickRescanLink) { 647 TEST_F(ChooserContentViewTest, ClickRescanLink) {
651 EXPECT_CALL(*mock_chooser_controller_, RefreshOptions()).Times(1); 648 EXPECT_CALL(*mock_chooser_controller_, RefreshOptions()).Times(1);
652 chooser_content_view_->LinkClicked(discovery_state_.get(), 0); 649 chooser_content_view_->LinkClicked(discovery_state_.get(), 0);
653 } 650 }
654 651
655 TEST_F(ChooserContentViewTest, ClickStyledLabelLink) { 652 TEST_F(ChooserContentViewTest, ClickStyledLabelLink) {
656 EXPECT_CALL(*mock_chooser_controller_, OpenHelpCenterUrl()).Times(1); 653 EXPECT_CALL(*mock_chooser_controller_, OpenHelpCenterUrl()).Times(1);
657 styled_label_->LinkClicked(nullptr, 0); 654 help_link_->LinkClicked(nullptr, 0);
658 } 655 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698