Make "to allow pairing" not be a link in the WebBluetooth chooser

Make "to allow pairing" not be a link in the WebBluetooth chooser

When the Bluetooth adapter is off, the chooser will show:
"Turn on Bluetooth to allow pairing", the whole text is a link.
This CL modifies code to make only "Turn on Bluetooth" a link.
And the "to allow pairing" text is not a link.

I uploaded some screenshots in the issue page.

BUG=658094
Committed: https://crrev.com/aa577cb63de06844e1ea65db7aa4f228a050a423
Cr-Commit-Position: refs/heads/master@{#427116}

[juncai, 2016-10-22 01:34:44]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-22 01:35:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-10-22 02:32:07]

Description was changed from

==========
Make "to allow pairing" not be a link in the WebBluetooth chooser

When the Bluetooth adapter is off, the chooser will show:
"Turn on Bluetooth to allow pairing", the whole text is a link.
This CL modifies code to make only "Turn on Bluetooth" a link.
And the "to allow pairing" text is not a link.

BUG=658094
==========

to

==========
Make "to allow pairing" not be a link in the WebBluetooth chooser

When the Bluetooth adapter is off, the chooser will show:
"Turn on Bluetooth to allow pairing", the whole text is a link.
This CL modifies code to make only "Turn on Bluetooth" a link.
And the "to allow pairing" text is not a link.

I uploaded some screenshots in the issue page.

BUG=658094
==========

[commit-bot: I haz the power, 2016-10-22 04:12:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-22 04:12:45]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-10-22 05:08:10]

juncai@chromium.org changed reviewers:
+ rsesek@chromium.org, sky@chromium.org

[juncai, 2016-10-22 05:08:11]

sky@chromium.org: Please review changes in 
//chrome/browser/ui/views

rsesek@chromium.org: Please review changes in 
//chrome/browser/ui/cocoa

[Robert Sesek, 2016-10-24 15:19:19]

cocoa/ LGTM

[sky, 2016-10-24 16:26:41]

LGTM

https://codereview.chromium.org/2439453006/diff/1/chrome/browser/ui/views/cho...
File chrome/browser/ui/views/chooser_content_view.cc (right):

https://codereview.chromium.org/2439453006/diff/1/chrome/browser/ui/views/cho...
chrome/browser/ui/views/chooser_content_view.cc:63: base::string16 link =
l10n_util::GetStringUTF16(
link_text as link implies it's a url, when it isn't. link_text also better
matches the name of the constant being looked up.

https://codereview.chromium.org/2439453006/diff/1/chrome/browser/ui/views/cho...
File chrome/browser/ui/views/chooser_content_view.h (right):

https://codereview.chromium.org/2439453006/diff/1/chrome/browser/ui/views/cho...
chrome/browser/ui/views/chooser_content_view.h:87: views::TableView* table_view_
= nullptr;               // Weak.
optional: IMO trying to format these comments to align across multiple lines
leads to needless changes. The style guide doesn't say this should be done, so I
would be inclined to remove the formatting and just use two spaces.

[juncai, 2016-10-24 17:41:58]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 17:42:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 18:42:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 18:42:07]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-10-24 18:51:44]

https://codereview.chromium.org/2439453006/diff/1/chrome/browser/ui/views/cho...
File chrome/browser/ui/views/chooser_content_view.cc (right):

https://codereview.chromium.org/2439453006/diff/1/chrome/browser/ui/views/cho...
chrome/browser/ui/views/chooser_content_view.cc:63: base::string16 link =
l10n_util::GetStringUTF16(
On 2016/10/24 16:26:40, sky wrote:
> link_text as link implies it's a url, when it isn't. link_text also better
> matches the name of the constant being looked up.

Done.

https://codereview.chromium.org/2439453006/diff/1/chrome/browser/ui/views/cho...
File chrome/browser/ui/views/chooser_content_view.h (right):

https://codereview.chromium.org/2439453006/diff/1/chrome/browser/ui/views/cho...
chrome/browser/ui/views/chooser_content_view.h:87: views::TableView* table_view_
= nullptr;               // Weak.
On 2016/10/24 16:26:40, sky wrote:
> optional: IMO trying to format these comments to align across multiple lines
> leads to needless changes. The style guide doesn't say this should be done, so
I
> would be inclined to remove the formatting and just use two spaces.

Done.

[juncai, 2016-10-24 18:51:57]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-10-24 18:51:57]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2439453006/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2016-10-24 18:52:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 19:28:00]

Description was changed from

==========
Make "to allow pairing" not be a link in the WebBluetooth chooser

When the Bluetooth adapter is off, the chooser will show:
"Turn on Bluetooth to allow pairing", the whole text is a link.
This CL modifies code to make only "Turn on Bluetooth" a link.
And the "to allow pairing" text is not a link.

I uploaded some screenshots in the issue page.

BUG=658094
==========

to

==========
Make "to allow pairing" not be a link in the WebBluetooth chooser

When the Bluetooth adapter is off, the chooser will show:
"Turn on Bluetooth to allow pairing", the whole text is a link.
This CL modifies code to make only "Turn on Bluetooth" a link.
And the "to allow pairing" text is not a link.

I uploaded some screenshots in the issue page.

BUG=658094
==========

[commit-bot: I haz the power, 2016-10-24 19:28:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-24 19:55:42]

Description was changed from

==========
Make "to allow pairing" not be a link in the WebBluetooth chooser

When the Bluetooth adapter is off, the chooser will show:
"Turn on Bluetooth to allow pairing", the whole text is a link.
This CL modifies code to make only "Turn on Bluetooth" a link.
And the "to allow pairing" text is not a link.

I uploaded some screenshots in the issue page.

BUG=658094
==========

to

==========
Make "to allow pairing" not be a link in the WebBluetooth chooser

When the Bluetooth adapter is off, the chooser will show:
"Turn on Bluetooth to allow pairing", the whole text is a link.
This CL modifies code to make only "Turn on Bluetooth" a link.
And the "to allow pairing" text is not a link.

I uploaded some screenshots in the issue page.

BUG=658094

Committed: https://crrev.com/aa577cb63de06844e1ea65db7aa4f228a050a423
Cr-Commit-Position: refs/heads/master@{#427116}
==========

[commit-bot: I haz the power, 2016-10-24 19:55:43]

Patchset 2 (id:??) landed as
https://crrev.com/aa577cb63de06844e1ea65db7aa4f228a050a423
Cr-Commit-Position: refs/heads/master@{#427116}