[Devtools] Removed dependency of networkLogView and dataGrid

[Devtools] Removed dependency of networkLogView and dataGrid

Removed dependency of networkLogView and dataGrid from new network
timeline canvas experiment.

R=dgozman
BUG=653738
Committed: https://crrev.com/6950f20e996680a3075bbd6a094db90b3ac67b31
Cr-Commit-Position: refs/heads/master@{#426713}

[allada, 2016-10-20 01:54:36]

Patchset #1 (id:1) has been deleted

[allada, 2016-10-20 01:54:43]

PTL

[dgozman, 2016-10-20 20:52:00]

https://codereview.chromium.org/2439453003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
(right):

https://codereview.chromium.org/2439453003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:157:
this._requestData = requests;
Don't we have to update() here? If not, should we instead pass requests to
update() call? Having these two being separate looks strange.

https://codereview.chromium.org/2439453003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:242:
update: function()
If we don't pass any data, I feel like this is "redraw", not "update".

[allada, 2016-10-20 21:08:31]

https://codereview.chromium.org/2439453003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
(right):

https://codereview.chromium.org/2439453003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:157:
this._requestData = requests;
On 2016/10/20 20:52:00, dgozman wrote:
> Don't we have to update() here? If not, should we instead pass requests to
> update() call? Having these two being separate looks strange.

At first I was doing an update here, however I changed it because the places
where this is being called are deciding to do an update or not. This gives the
ability where something may call an event in data grid that calls an update() to
the canvas multiple times but may only need to send the requests in once.

In short, I agree it looks strange, but there may be something that removes
items one at a time (like filter or sort) but only do a paint/layout once. This
helps keep the data up to date, but let the draw part manage when to show it.

[allada, 2016-10-20 22:30:37]

Patchset #2 (id:40001) has been deleted

[allada, 2016-10-20 22:34:49]

Patchset #3 (id:50003) has been deleted

[allada, 2016-10-20 22:35:05]

PTL

https://codereview.chromium.org/2439453003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
(right):

https://codereview.chromium.org/2439453003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:242:
update: function()
On 2016/10/20 20:52:00, dgozman wrote:
> If we don't pass any data, I feel like this is "redraw", not "update".

Done.

[dgozman, 2016-10-20 23:20:08]

lgtm

https://codereview.chromium.org/2439453003/diff/90001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2439453003/diff/90001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:334:
this._timelineColumn.draw();
Let's add an optional |requests| parameter to draw and rename it back to update.

[allada, 2016-10-20 23:48:20]

done

https://codereview.chromium.org/2439453003/diff/90001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2439453003/diff/90001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:334:
this._timelineColumn.draw();
On 2016/10/20 23:20:08, dgozman wrote:
> Let's add an optional |requests| parameter to draw and rename it back to
update.

Done.

[allada, 2016-10-20 23:48:24]

The CQ bit was checked by allada@chromium.org

[allada, 2016-10-20 23:48:24]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2439453003/#ps110001
(title: "changes")

[commit-bot: I haz the power, 2016-10-20 23:48:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 03:41:47]

Committed patchset #4 (id:110001)

[commit-bot: I haz the power, 2016-10-21 13:26:54]

Description was changed from

==========
[Devtools] Removed dependency of networkLogView and dataGrid

Removed dependency of networkLogView and dataGrid from new network
timeline canvas experiment.

R=dgozman
BUG=653738
==========

to

==========
[Devtools] Removed dependency of networkLogView and dataGrid

Removed dependency of networkLogView and dataGrid from new network
timeline canvas experiment.

R=dgozman
BUG=653738

Committed: https://crrev.com/6950f20e996680a3075bbd6a094db90b3ac67b31
Cr-Commit-Position: refs/heads/master@{#426713}
==========

[commit-bot: I haz the power, 2016-10-21 13:26:55]

Patchset 4 (id:??) landed as
https://crrev.com/6950f20e996680a3075bbd6a094db90b3ac67b31
Cr-Commit-Position: refs/heads/master@{#426713}