Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2436953003: [Devtools] Highlight navigation request in network timeline exp (Closed)

Created:
4 years, 2 months ago by allada
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Highlight navigation request in network timeline exp Added navigation row highlighting to canvas in network timeline expiriment. See: http://imgur.com/a/GwrDe R=dgozman BUG=653738 Committed: https://crrev.com/6a25a8439bffff380d71c83eedc1ee520a9cd5fb Cr-Commit-Position: refs/heads/master@{#426954}

Patch Set 1 : [Devtools] Highlight navigation request in network timeline exp #

Total comments: 1

Patch Set 2 : Merge branch 'NETWORK_TIMELINE_9_REMOVE_DEPENDENCY' into NETWORK_TIMELINE_10_ADD_COLOR_NAVIGATION #

Total comments: 4

Patch Set 3 : changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -22 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 1 2 2 chunks +15 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js View 1 2 3 chunks +17 lines, -8 lines 0 comments Download

Depends on Patchset:

Issue 2439453003 Patch 110001

Dependent Patchsets:

Issue 2438683004 Patch 100001

Messages

Total messages: 10 (4 generated)
allada
PTL https://codereview.chromium.org/2436953003/diff/20001/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js File third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js (right): https://codereview.chromium.org/2436953003/diff/20001/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js#newcode66 third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:66: this._rowHoverColor = WebInspector.themeSupport.patchColor("#ebf2fc", /** @type {!WebInspector.ThemeSupport.ColorUsage} */ (colorUsage.Background ...
4 years, 2 months ago (2016-10-20 23:30:43 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2436953003/diff/40001/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/2436953003/diff/40001/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js#newcode333 third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:333: this._timelineColumn.draw(); There is no |draw| method. https://codereview.chromium.org/2436953003/diff/40001/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js#newcode338 third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:338: ...
4 years, 2 months ago (2016-10-21 20:39:21 UTC) #3
allada
done https://codereview.chromium.org/2436953003/diff/40001/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/2436953003/diff/40001/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js#newcode333 third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:333: this._timelineColumn.draw(); On 2016/10/21 20:39:21, dgozman wrote: > There ...
4 years, 2 months ago (2016-10-21 22:22:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436953003/60001
4 years, 2 months ago (2016-10-21 22:23:15 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 2 months ago (2016-10-22 02:23:45 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-22 02:28:44 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/6a25a8439bffff380d71c83eedc1ee520a9cd5fb
Cr-Commit-Position: refs/heads/master@{#426954}

Powered by Google App Engine
This is Rietveld 408576698