Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: blimp/net/engine_connection_manager.cc

Issue 2439403003: Refactor BlimpConnection to TCPConnection (Closed)
Patch Set: Sync merge Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/engine_connection_manager.cc
diff --git a/blimp/net/engine_connection_manager.cc b/blimp/net/engine_connection_manager.cc
index 8e74fbdf7d05f3695926714ab4514ed503579575..56dbb3dc2d8e8c605434dfabb7a66823db005a0f 100644
--- a/blimp/net/engine_connection_manager.cc
+++ b/blimp/net/engine_connection_manager.cc
@@ -11,37 +11,46 @@
#include "blimp/net/blimp_connection.h"
#include "blimp/net/blimp_transport.h"
#include "blimp/net/message_port.h"
+#include "blimp/net/tcp_engine_transport.h"
+#include "net/base/ip_address.h"
#include "net/base/net_errors.h"
namespace blimp {
EngineConnectionManager::EngineConnectionManager(
- ConnectionHandler* connection_handler)
- : connection_handler_(connection_handler) {
+ ConnectionHandler* connection_handler, net::NetLog* net_log)
+ : connection_handler_(connection_handler), net_log_(net_log) {
DCHECK(connection_handler_);
}
EngineConnectionManager::~EngineConnectionManager() {}
-void EngineConnectionManager::AddTransport(
- std::unique_ptr<BlimpTransport> transport) {
- BlimpTransport* transport_ptr = transport.get();
- transports_.push_back(std::move(transport));
- Connect(transport_ptr);
-}
-
-void EngineConnectionManager::Connect(BlimpTransport* transport) {
- transport->Connect(base::Bind(&EngineConnectionManager::OnConnectResult,
- base::Unretained(this),
- base::Unretained(transport)));
+void EngineConnectionManager::ConnectTransport(
+ const net::IPEndPoint& ip_endpoint, EngineTransportType transport_type) {
+ switch (transport_type) {
+ case EngineTransportType::TCP: {
+ transport_ = base::MakeUnique<TCPEngineTransport>(ip_endpoint, net_log_);
+ break;
+ }
+
+ case EngineTransportType::GRPC: {
+ LOG(FATAL) << "gRPC support not yet implemented.";
+ // TODO(perumaal): Unimplemented as yet.
+ // transport_ =
+ // base::MakeUnique<GrpcEngineTransport>(ip_endpoint.ToString());
+ break;
+ }
+ }
+
+ transport_->Connect(base::Bind(&EngineConnectionManager::OnConnectResult,
+ base::Unretained(this),
+ base::Unretained(transport_.get())));
}
void EngineConnectionManager::OnConnectResult(BlimpTransport* transport,
int result) {
CHECK_EQ(net::OK, result) << "Transport failure:" << transport->GetName();
- connection_handler_->HandleConnection(
- base::MakeUnique<BlimpConnection>(transport->TakeMessagePort()));
- Connect(transport);
+ connection_handler_->HandleConnection(transport->MakeConnection());
}
} // namespace blimp

Powered by Google App Engine
This is Rietveld 408576698