Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: blimp/common/proto/BUILD.gn

Issue 2439403003: Refactor BlimpConnection to TCPConnection (Closed)
Patch Set: Sync merge Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/common/proto/BUILD.gn
diff --git a/blimp/common/proto/BUILD.gn b/blimp/common/proto/BUILD.gn
index c75c5b981a6fa763be725b33be793f23d1bf8611..b3e09ca63df4ba8a901484dfdd9c8a7938141be3 100644
--- a/blimp/common/proto/BUILD.gn
+++ b/blimp/common/proto/BUILD.gn
@@ -7,6 +7,7 @@ import("//third_party/protobuf/proto_library.gni")
group("proto") {
public_deps = [
":blimp_proto",
+ ":grpc_service",
"//third_party/protobuf:protobuf_lite",
]
}
@@ -16,10 +17,24 @@ component("blimp_proto") {
visibility = [ ":proto" ]
public_deps = [
+ ":grpc_service",
":proto_internal",
]
}
+proto_library("grpc_service") {
Garrett Casto 2016/10/25 18:33:49 Seems like this should be part of the next CL.
perumaal 2016/10/25 23:02:38 Sure, just wanted to see what's the best route for
+ sources = [
+ "grpc_service.proto",
+ ]
+
+ generator_plugin_label = "//third_party/grpc:grpc_cpp_plugin"
+ generator_plugin_suffix = ".grpc.pb"
+
+ deps = [
+ "//third_party/grpc:grpc++_unsecure",
+ ]
+}
+
proto_library("proto_internal") {
# Only expose the target to the "blimp_proto" target.
visibility = [ ":blimp_proto" ]

Powered by Google App Engine
This is Rietveld 408576698