Refactor BlimpConnection to TCPConnection

blimp/client/core/session/client_network_components.cc

Index: blimp/client/core/session/client_network_components.cc
diff --git a/blimp/client/core/session/client_network_components.cc b/blimp/client/core/session/client_network_components.cc
index f8ce52490e48879aead78d0c7656ada5c1bf7a7b..77b6c1a2fbae2197a894e33dafd3506fd3695e6f 100644
--- a/blimp/client/core/session/client_network_components.cc
+++ b/blimp/client/core/session/client_network_components.cc
@@ -35,6 +35,7 @@ void ClientNetworkComponents::ConnectWithAssignment(
 
   connection_manager_->set_client_auth_token(assignment.client_auth_token);
   const char* transport_type = "UNKNOWN";
+  auto endpoint = assignment.engine_endpoint.ToString();

[Garrett Casto, 2016/10/25 18:33:49]

Nit: I'm not sure why you pulled this out. It doesn't look like it's referenced
anywhere new. Given the scale of the refactoring here, I would generally try to
avoid making small cosmetic changes like this because it just complicates the
diff.

[Kevin M, 2016/10/25 18:49:22]

Just inline this in VLOG? Otherwise we are computing strings on release builds.

Side notes:
* err on the side of using an explicit type over "auto" for variables with a
nontrivial binding lifetime.

[perumaal, 2016/10/25 23:02:38]

Done.

   switch (assignment.transport_protocol) {
     case Assignment::SSL:
       DCHECK(assignment.cert);
@@ -47,13 +48,19 @@ void ClientNetworkComponents::ConnectWithAssignment(
           assignment.engine_endpoint, nullptr));
       transport_type = "TCP";
       break;
+    case Assignment::GRPC:
+      // TODO(perumaal): Unimplemented as yet.

[Kevin M, 2016/10/25 18:49:22]

NOTIMPLEMENTED() ?

[perumaal, 2016/10/25 23:02:38]

Nice! thx

+      // connection_manager_->AddTransport(
+      // base::MakeUnique<GrpcClientTransport>(endpoint));
+      transport_type = "GRPC";
+      LOG(FATAL) << "Not yet implemented!";
+      break;
     case Assignment::UNKNOWN:
       LOG(FATAL) << "Unknown transport type.";
       break;
   }
 
-  VLOG(1) << "Connecting to " << assignment.engine_endpoint.ToString() << " ("
-          << transport_type << ")";
+  VLOG(1) << "Connecting to " << endpoint << " (" << transport_type << ")";
 
   connection_manager_->Connect();
 }