Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: blimp/net/client_connection_manager.cc

Issue 2439403003: Refactor BlimpConnection to TCPConnection (Closed)
Patch Set: Added missing Engine Transport Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/client_connection_manager.cc
diff --git a/blimp/net/client_connection_manager.cc b/blimp/net/client_connection_manager.cc
index 4218b2d512796e53e5b15e2a8b0a9bad41f075e8..32c13d1439350e3d6ef6afc423cd9aa67e29311f 100644
--- a/blimp/net/client_connection_manager.cc
+++ b/blimp/net/client_connection_manager.cc
@@ -57,9 +57,9 @@ void ClientConnectionManager::Connect(int transport_index) {
void ClientConnectionManager::OnConnectResult(int transport_index, int result) {
DCHECK_NE(result, net::ERR_IO_PENDING);
const auto& transport = transports_[transport_index];
+ DVLOG(1) << "OnConnectResult; result = " << result;
if (result == net::OK) {
- std::unique_ptr<BlimpConnection> connection =
- base::MakeUnique<BlimpConnection>(transport->TakeMessagePort());
+ std::unique_ptr<BlimpConnection> connection = transport->MakeConnection();
connection->AddConnectionErrorObserver(this);
SendAuthenticationMessage(std::move(connection));
} else {

Powered by Google App Engine
This is Rietveld 408576698