Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2598)

Unified Diff: blimp/net/blimp_transport.h

Issue 2439403003: Refactor BlimpConnection to TCPConnection (Closed)
Patch Set: Added missing Engine Transport Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/blimp_transport.h
diff --git a/blimp/net/blimp_transport.h b/blimp/net/blimp_transport.h
index 5d06632b2e9af0d5bc18c62f8af78c167922c177..098e880f67099ca0b60f7f883d50a133b726c78e 100644
--- a/blimp/net/blimp_transport.h
+++ b/blimp/net/blimp_transport.h
@@ -13,7 +13,6 @@
namespace blimp {
class BlimpConnection;
-class MessagePort;
// An interface which encapsulates the transport-specific code for
// establishing network connections between the client and engine.
@@ -26,13 +25,14 @@ class BlimpTransport {
// Initiate or listen for a connection.
//
// |callback| is passed net::OK if a connection was successfully
- // established. The connection's MessagePort can then be taken by calling
- // TakeMessagePort().
+ // established.
// All other values indicate a connection error.
virtual void Connect(const net::CompletionCallback& callback) = 0;
- // Returns the MessagePort of a successfully established connection.
- virtual std::unique_ptr<MessagePort> TakeMessagePort() = 0;
+ // Creates a new |BlimpConnection| for the specific |BlimpTransport|
+ // implementation. Must not be called until |Connect|'s callback returns
+ // net::OK.
+ virtual std::unique_ptr<BlimpConnection> MakeConnection() = 0;
// Gets the transport name, e.g. "TCP", "SSL", "mock", etc.
virtual const char* GetName() const = 0;

Powered by Google App Engine
This is Rietveld 408576698