Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1297)

Unified Diff: blimp/engine/browser_tests/blimp_browser_test.cc

Issue 2439403003: Refactor BlimpConnection to TCPConnection (Closed)
Patch Set: Added missing Engine Transport Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/browser_tests/blimp_browser_test.cc
diff --git a/blimp/engine/browser_tests/blimp_browser_test.cc b/blimp/engine/browser_tests/blimp_browser_test.cc
index e8ed5b9eaa55cb6c4b6f4c94f8933a0dfa56b68d..5440666b78bc7c6c17ce1aafb9586ddbde53d46c 100644
--- a/blimp/engine/browser_tests/blimp_browser_test.cc
+++ b/blimp/engine/browser_tests/blimp_browser_test.cc
@@ -93,6 +93,8 @@ void BlimpBrowserTest::SetUpCommandLine(base::CommandLine* command_line) {
command_line->AppendSwitchASCII(blimp::engine::kEnginePort, "0");
}
+ // TODO(perumaal): Switch to gRPC when it's ready. See crbug.com/659279.
Wez 2016/11/09 22:47:17 nit: Similarly, this placeholder doesn't really ad
perumaal 2016/11/10 02:05:05 These are more like breadcrumbs for me to track an
+
base::FilePath src_root;
PathService::Get(base::DIR_SOURCE_ROOT, &src_root);
command_line->AppendSwitchASCII(

Powered by Google App Engine
This is Rietveld 408576698