Refactor BlimpConnection to TCPConnection

blimp/engine/browser_tests/blimp_browser_test.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/engine/browser_tests/blimp_browser_test.h"
 
 #include <string>
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
@@ skipping 75 matching lines @@
 void BlimpBrowserTest::SetUpCommandLine(base::CommandLine* command_line) {
   // Engine switches.
   blimp::engine::SetCommandLineDefaults(command_line);
 
   // Pass through the engine port if it is passed to the test.
   // Otherwise, use a dynamic port.
   if (!command_line->HasSwitch(blimp::engine::kEnginePort)) {
     command_line->AppendSwitchASCII(blimp::engine::kEnginePort, "0");
   }
 
+  // TODO(perumaal): Switch to gRPC when it's ready. See crbug.com/659279.

[Wez, 2016/11/09 22:47:17]

nit: Similarly, this placeholder doesn't really add anything that the bug
doesn't already contain.

[perumaal, 2016/11/10 02:05:05]

These are more like breadcrumbs for me to track and also help the reviewers
understand where the gRPC pieces fit in... but I agree it's duplicating what's
in the bug.

It's hard to see the big picture otherwise IMO as a reviewer without these
bread-crumbs, so one way would be for me to remove these before checkin.

+
   base::FilePath src_root;
   PathService::Get(base::DIR_SOURCE_ROOT, &src_root);
   command_line->AppendSwitchASCII(
       kClientAuthTokenPath, src_root.Append(kClientAuthTokenFilePath).value());
 }
 
 void BlimpBrowserTest::SetUpOnMainThread() {
   // Get the connection's port number across the IO/UI thread boundary.
   GetEngineSession()->GetEnginePortForTesting(base::Bind(
       &BlimpBrowserTest::OnGetEnginePortCompletion, base::Unretained(this)));
@@ skipping 19 matching lines @@
     i.GetCurrentValue()->FastShutdownIfPossible();
   }
 }
 
 void BlimpBrowserTest::OnGetEnginePortCompletion(uint16_t port) {
   engine_port_ = port;
   SignalCompletion();
 }
 
 }  // namespace blimp