Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: blimp/client/core/session/client_network_components.cc

Issue 2439403003: Refactor BlimpConnection to TCPConnection (Closed)
Patch Set: Added missing Engine Transport Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/session/client_network_components.cc
diff --git a/blimp/client/core/session/client_network_components.cc b/blimp/client/core/session/client_network_components.cc
index f8ce52490e48879aead78d0c7656ada5c1bf7a7b..45f722aeae43b3a0250b515210ae128f649633e6 100644
--- a/blimp/client/core/session/client_network_components.cc
+++ b/blimp/client/core/session/client_network_components.cc
@@ -47,6 +47,13 @@ void ClientNetworkComponents::ConnectWithAssignment(
assignment.engine_endpoint, nullptr));
transport_type = "TCP";
break;
+ case Assignment::GRPC:
+ // TODO(perumaal): Unimplemented as yet.
+ // connection_manager_->AddTransport(
+ // base::MakeUnique<GrpcClientTransport>(endpoint));
+ transport_type = "GRPC";
+ NOTIMPLEMENTED();
Wez 2016/11/09 22:47:17 nit: For future CLs, please don't add flags for un
perumaal 2016/11/10 02:05:05 Got it.
+ break;
case Assignment::UNKNOWN:
LOG(FATAL) << "Unknown transport type.";
break;

Powered by Google App Engine
This is Rietveld 408576698