Refactor BlimpConnection to TCPConnection

blimp/client/core/session/client_network_components.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/client/core/session/client_network_components.h"
 
 #include <utility>
 
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
@@ skipping 29 matching lines @@
       DCHECK(assignment.cert);
       connection_manager_->AddTransport(base::MakeUnique<SSLClientTransport>(
           assignment.engine_endpoint, std::move(assignment.cert), nullptr));
       transport_type = "SSL";
       break;
     case Assignment::TCP:
       connection_manager_->AddTransport(base::MakeUnique<TCPClientTransport>(
           assignment.engine_endpoint, nullptr));
       transport_type = "TCP";
       break;
+    case Assignment::GRPC:
+      // TODO(perumaal): Unimplemented as yet.
+      // connection_manager_->AddTransport(
+      // base::MakeUnique<GrpcClientTransport>(endpoint));
+      transport_type = "GRPC";
+      NOTIMPLEMENTED();

[Wez, 2016/11/09 22:47:17]

nit: For future CLs, please don't add flags for un-implemented features like
this; just add the flag when you add the feature.

[perumaal, 2016/11/10 02:05:05]

Got it.

+      break;
     case Assignment::UNKNOWN:
       LOG(FATAL) << "Unknown transport type.";
       break;
   }
 
   VLOG(1) << "Connecting to " << assignment.engine_endpoint.ToString() << " ("
           << transport_type << ")";
 
   connection_manager_->Connect();
 }
@@ skipping 18 matching lines @@
   if (result >= 0) {
     VLOG(1) << "Disconnected with reason: " << result;
   } else {
     VLOG(1) << "Connection error: " << net::ErrorToString(result);
   }
   network_observer_->OnDisconnected(result);
 }
 
 }  // namespace client
 }  // namespace blimp