Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: recipe_modules/bot_update/__init__.py

Issue 2439373002: bot_update: understand new Gerrit patch properties. (Closed)
Patch Set: lint Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | recipe_modules/bot_update/api.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_modules/bot_update/__init__.py
diff --git a/recipe_modules/bot_update/__init__.py b/recipe_modules/bot_update/__init__.py
index 7846a68ad0669b48e1f6f08b7c6cf3ba509fef69..8e44beee13d431a64a870ba2d7bbd175d1e446be 100644
--- a/recipe_modules/bot_update/__init__.py
+++ b/recipe_modules/bot_update/__init__.py
@@ -15,14 +15,27 @@ from recipe_engine.recipe_api import Property
from recipe_engine.types import freeze
PROPERTIES = {
+ # Gerrit patches will have all properties about them prefixed with patch_.
+ 'patch_issue': Property(default=None), # TODO(tandrii): add kind=int.
+ 'patch_set': Property(default=None), # TODO(tandrii): add kind=int.
+ 'patch_project': Property(default=None), # Also used by Rietveld.
+ 'patch_gerrit_url': Property(default=None),
+ 'patch_repository_url': Property(default=None),
+ 'patch_ref': Property(default=None),
+
+ # TODO(tAndrii): remove legacy Gerrit fields.
+ # Legacy Gerrit fields.
+ 'event.patchSet.ref': Property(default=None, param_name='gerrit_ref'),
+
+ # Rietveld-only fields.
+ 'rietveld': Property(default=None), # Stores Url of Rietveld server.
'issue': Property(default=None),
'patchset': Property(default=None),
- 'patch_project': Property(default=None),
'repository': Property(default=None),
- 'event.patchSet.ref': Property(default=None, param_name="gerrit_ref"),
- 'rietveld': Property(default=None),
- 'revision': Property(default=None),
- 'parent_got_revision': Property(default=None),
+
+ # Common fields for both systems.
'deps_revision_overrides': Property(default=freeze({})),
'fail_patch': Property(default=None, kind=str),
+ 'parent_got_revision': Property(default=None),
+ 'revision': Property(default=None),
}
« no previous file with comments | « no previous file | recipe_modules/bot_update/api.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698