Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Side by Side Diff: recipe_modules/bot_update/__init__.py

Issue 2439373002: bot_update: understand new Gerrit patch properties. (Closed)
Patch Set: lint Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | recipe_modules/bot_update/api.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 DEPS = [ 1 DEPS = [
2 'gclient', 2 'gclient',
3 'recipe_engine/json', 3 'recipe_engine/json',
4 'recipe_engine/path', 4 'recipe_engine/path',
5 'recipe_engine/platform', 5 'recipe_engine/platform',
6 'recipe_engine/properties', 6 'recipe_engine/properties',
7 'recipe_engine/python', 7 'recipe_engine/python',
8 'recipe_engine/raw_io', 8 'recipe_engine/raw_io',
9 'rietveld', 9 'rietveld',
10 'recipe_engine/step', 10 'recipe_engine/step',
11 'tryserver', 11 'tryserver',
12 ] 12 ]
13 13
14 from recipe_engine.recipe_api import Property 14 from recipe_engine.recipe_api import Property
15 from recipe_engine.types import freeze 15 from recipe_engine.types import freeze
16 16
17 PROPERTIES = { 17 PROPERTIES = {
18 # Gerrit patches will have all properties about them prefixed with patch_.
19 'patch_issue': Property(default=None), # TODO(tandrii): add kind=int.
20 'patch_set': Property(default=None), # TODO(tandrii): add kind=int.
21 'patch_project': Property(default=None), # Also used by Rietveld.
22 'patch_gerrit_url': Property(default=None),
23 'patch_repository_url': Property(default=None),
24 'patch_ref': Property(default=None),
25
26 # TODO(tAndrii): remove legacy Gerrit fields.
27 # Legacy Gerrit fields.
28 'event.patchSet.ref': Property(default=None, param_name='gerrit_ref'),
29
30 # Rietveld-only fields.
31 'rietveld': Property(default=None), # Stores Url of Rietveld server.
18 'issue': Property(default=None), 32 'issue': Property(default=None),
19 'patchset': Property(default=None), 33 'patchset': Property(default=None),
20 'patch_project': Property(default=None),
21 'repository': Property(default=None), 34 'repository': Property(default=None),
22 'event.patchSet.ref': Property(default=None, param_name="gerrit_ref"), 35
23 'rietveld': Property(default=None), 36 # Common fields for both systems.
24 'revision': Property(default=None),
25 'parent_got_revision': Property(default=None),
26 'deps_revision_overrides': Property(default=freeze({})), 37 'deps_revision_overrides': Property(default=freeze({})),
27 'fail_patch': Property(default=None, kind=str), 38 'fail_patch': Property(default=None, kind=str),
39 'parent_got_revision': Property(default=None),
40 'revision': Property(default=None),
28 } 41 }
OLDNEW
« no previous file with comments | « no previous file | recipe_modules/bot_update/api.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698