Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: recipe_modules/bot_update/__init__.py

Issue 2439373002: bot_update: understand new Gerrit patch properties. (Closed)
Patch Set: Expectations. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | recipe_modules/bot_update/api.py » ('j') | recipe_modules/bot_update/api.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_modules/bot_update/__init__.py
diff --git a/recipe_modules/bot_update/__init__.py b/recipe_modules/bot_update/__init__.py
index 7846a68ad0669b48e1f6f08b7c6cf3ba509fef69..38616b6a19c39d0cb57cf9161905ccf6e0068166 100644
--- a/recipe_modules/bot_update/__init__.py
+++ b/recipe_modules/bot_update/__init__.py
@@ -16,10 +16,15 @@ from recipe_engine.types import freeze
PROPERTIES = {
'issue': Property(default=None),
+ 'patch_issue': Property(default=None),
'patchset': Property(default=None),
Michael Achenbach 2016/10/24 08:18:13 Maybe leave a comment here about the difference be
tandrii(chromium) 2016/10/24 11:43:37 Refactored this code. Yesterday I believed the ord
+ 'patch_set': Property(default=None),
'patch_project': Property(default=None),
'repository': Property(default=None),
- 'event.patchSet.ref': Property(default=None, param_name="gerrit_ref"),
+ 'patch_repository_url': Property(default=None),
+ 'event.patchSet.ref': Property(default=None, param_name='gerrit_ref'),
Michael Achenbach 2016/10/24 08:18:13 nit: how about some alpha or other sorting of keys
tandrii(chromium) 2016/10/24 11:43:37 Done.
+ 'patch_ref': Property(default=None),
+ 'patch_gerrit_url': Property(default=None),
'rietveld': Property(default=None),
'revision': Property(default=None),
'parent_got_revision': Property(default=None),
« no previous file with comments | « no previous file | recipe_modules/bot_update/api.py » ('j') | recipe_modules/bot_update/api.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698