bot_update: understand new Gerrit patch properties.

recipe_modules/bot_update/__init__.py

 DEPS = [
   'gclient',
   'recipe_engine/json',
   'recipe_engine/path',
   'recipe_engine/platform',
   'recipe_engine/properties',
   'recipe_engine/python',
   'recipe_engine/raw_io',
   'rietveld',
   'recipe_engine/step',
   'tryserver',
 ]
 
 from recipe_engine.recipe_api import Property
 from recipe_engine.types import freeze
 
 PROPERTIES = {
   'issue': Property(default=None),
+  'patch_issue': Property(default=None),
   'patchset': Property(default=None),

[Michael Achenbach, 2016/10/24 08:18:13]

Maybe leave a comment here about the difference between the two patch*sets

[tandrii(chromium), 2016/10/24 11:43:37]

Refactored this code. Yesterday I believed the order is the same as the order in
constructor of API object. Of course not. So, I can re-order at will.

+  'patch_set': Property(default=None),
   'patch_project': Property(default=None),
   'repository': Property(default=None),
-  'event.patchSet.ref': Property(default=None, param_name="gerrit_ref"),
+  'patch_repository_url': Property(default=None),
+  'event.patchSet.ref': Property(default=None, param_name='gerrit_ref'),

[Michael Achenbach, 2016/10/24 08:18:13]

nit: how about some alpha or other sorting of keys (e.g. rietveld/gerrit/rest)?

[tandrii(chromium), 2016/10/24 11:43:37]

Done.

+  'patch_ref': Property(default=None),
+  'patch_gerrit_url': Property(default=None),
   'rietveld': Property(default=None),
   'revision': Property(default=None),
   'parent_got_revision': Property(default=None),
   'deps_revision_overrides': Property(default=freeze({})),
   'fail_patch': Property(default=None, kind=str),
 }