Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2439263002: Disable FrameNavigationEntry_NewSubframe on Android due to flakes. (Closed)

Created:
4 years, 2 months ago by Łukasz Anforowicz
Modified:
4 years, 1 month ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable FrameNavigationEntry_NewSubframe on Android due to flakes. BUG=646836 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/7aafd756bccbb4a289b57870906e44e6a866d7a7 Cr-Commit-Position: refs/heads/master@{#427404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Łukasz Anforowicz
Charlie, can you take a look please? Details about recent flakes are in https://crbug.com/646836#c2
4 years, 2 months ago (2016-10-22 00:07:18 UTC) #3
Charlie Reis
LGTM. I think fixing this is just a matter of waiting for the C process ...
4 years, 1 month ago (2016-10-25 17:06:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439263002/1
4 years, 1 month ago (2016-10-25 17:10:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 17:49:29 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 18:03:23 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7aafd756bccbb4a289b57870906e44e6a866d7a7
Cr-Commit-Position: refs/heads/master@{#427404}

Powered by Google App Engine
This is Rietveld 408576698