Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Side by Side Diff: content/browser/frame_host/navigation_controller_impl_browsertest.cc

Issue 2439263002: Disable FrameNavigationEntry_NewSubframe on Android due to flakes. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/navigation_controller_impl.h" 5 #include "content/browser/frame_host/navigation_controller_impl.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 #include <algorithm> 8 #include <algorithm>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 2220 matching lines...) Expand 10 before | Expand all | Expand 10 after
2231 " +--Site B ------- proxies for A\n" 2231 " +--Site B ------- proxies for A\n"
2232 " +--Site A -- proxies for B\n" 2232 " +--Site A -- proxies for B\n"
2233 "Where A = http://127.0.0.1/\n" 2233 "Where A = http://127.0.0.1/\n"
2234 " B = http://foo.com/", 2234 " B = http://foo.com/",
2235 visualizer.DepictFrameTree(root)); 2235 visualizer.DepictFrameTree(root));
2236 } 2236 }
2237 } 2237 }
2238 2238
2239 // Verify the tree of FrameNavigationEntries after NAVIGATION_TYPE_NEW_SUBFRAME 2239 // Verify the tree of FrameNavigationEntries after NAVIGATION_TYPE_NEW_SUBFRAME
2240 // commits. 2240 // commits.
2241 // Disabled due to flakes on Linux Tests; see https://crbug.com/646836. 2241 // Disabled due to flakes; see https://crbug.com/646836.
2242 #if defined(OS_LINUX) 2242 #if defined(OS_ANDROID) || defined(OS_LINUX)
2243 #define MAYBE_FrameNavigationEntry_NewSubframe \ 2243 #define MAYBE_FrameNavigationEntry_NewSubframe \
2244 DISABLED_FrameNavigationEntry_NewSubframe 2244 DISABLED_FrameNavigationEntry_NewSubframe
2245 #else 2245 #else
2246 #define MAYBE_FrameNavigationEntry_NewSubframe FrameNavigationEntry_NewSubframe 2246 #define MAYBE_FrameNavigationEntry_NewSubframe FrameNavigationEntry_NewSubframe
2247 #endif 2247 #endif
2248 IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest, 2248 IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest,
2249 MAYBE_FrameNavigationEntry_NewSubframe) { 2249 MAYBE_FrameNavigationEntry_NewSubframe) {
2250 GURL main_url(embedded_test_server()->GetURL( 2250 GURL main_url(embedded_test_server()->GetURL(
2251 "/navigation_controller/simple_page_1.html")); 2251 "/navigation_controller/simple_page_1.html"));
2252 EXPECT_TRUE(NavigateToURL(shell(), main_url)); 2252 EXPECT_TRUE(NavigateToURL(shell(), main_url));
(...skipping 4621 matching lines...) Expand 10 before | Expand all | Expand 10 after
6874 // Verify that the extra header was NOT present for the subresource. 6874 // Verify that the extra header was NOT present for the subresource.
6875 const net::test_server::HttpRequest* image_request = 6875 const net::test_server::HttpRequest* image_request =
6876 FindAccumulatedRequest(image_url); 6876 FindAccumulatedRequest(image_url);
6877 ASSERT_TRUE(image_request); 6877 ASSERT_TRUE(image_request);
6878 EXPECT_THAT(image_request->headers, 6878 EXPECT_THAT(image_request->headers,
6879 testing::Not(testing::Contains( 6879 testing::Not(testing::Contains(
6880 testing::Key("X-ExtraHeadersVsSubresources")))); 6880 testing::Key("X-ExtraHeadersVsSubresources"))));
6881 } 6881 }
6882 6882
6883 } // namespace content 6883 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698