Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Unified Diff: third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-negative-offset-translucent-outline.html

Issue 2439113003: Fix the bug that negative outline-offset is covered up by composited (Closed)
Patch Set: Use rebaseline-o-matic because rebaseline-cl doesn't work on this Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-negative-offset-translucent-outline.html
diff --git a/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-negative-offset-translucent-outline.html b/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-negative-offset-translucent-outline.html
new file mode 100644
index 0000000000000000000000000000000000000000..23422476dc29dc04f735d38585e7df46f1d41ae4
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-negative-offset-translucent-outline.html
@@ -0,0 +1,38 @@
+<script>
+if (window.testRunner)
+ testRunner.waitUntilDone();
+onload = function() {
+ // Double rAF to ensure content is painted before scroll.
+ requestAnimationFrame(function() {
+ requestAnimationFrame(function() {
+ document.getElementById('scroller').scrollTop = 200;
flackr 2016/11/15 20:40:40 Is the double rAF or scrolling necessary? We alrea
yigu 2016/11/15 23:30:16 You are right. This is a redundant test.
+ if (window.testRunner)
+ window.testRunner.notifyDone();
+ })
+ });
+}
+</script>
+<style>
+#scroller {
+ background: gray local content-box;
flackr 2016/11/15 20:40:40 Why local content-box? I think just having backgro
yigu 2016/11/15 23:30:16 Done.
+ outline: 5px solid rgba(0, 255, 0, 0.5);
+ outline-offset: -4px;
+ overflow: scroll;
+ padding: 10px;
flackr 2016/11/15 20:40:40 nit: Remove unnecessary padding.
yigu 2016/11/15 23:30:16 Done.
+ width: 200px;
+ height: 200px;
+ box-sizing: border-box;
+ will-change: transform;
+}
+
+.spacer {
+ height: 300px;
+}
+</style>
+<!-- #scroller should not be covered up by a negative offset outline. It is
flackr 2016/11/15 20:40:40 This comment is confusing, the outline should be o
yigu 2016/11/15 23:30:16 Yes that was misleading.
+ achieved by painting the outline into the decoration layer which draws
+ on top of all other layers. -->
+<div id="scroller">
+ <div class="spacer"></div>
+</div>
+

Powered by Google App Engine
This is Rietveld 408576698