Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Side by Side Diff: third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-negative-offset-translucent-outline.html

Issue 2439113003: Fix the bug that negative outline-offset is covered up by composited (Closed)
Patch Set: Use rebaseline-o-matic because rebaseline-cl doesn't work on this Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 <script>
2 if (window.testRunner)
3 testRunner.waitUntilDone();
4 onload = function() {
5 // Double rAF to ensure content is painted before scroll.
6 requestAnimationFrame(function() {
7 requestAnimationFrame(function() {
8 document.getElementById('scroller').scrollTop = 200;
flackr 2016/11/15 20:40:40 Is the double rAF or scrolling necessary? We alrea
yigu 2016/11/15 23:30:16 You are right. This is a redundant test.
9 if (window.testRunner)
10 window.testRunner.notifyDone();
11 })
12 });
13 }
14 </script>
15 <style>
16 #scroller {
17 background: gray local content-box;
flackr 2016/11/15 20:40:40 Why local content-box? I think just having backgro
yigu 2016/11/15 23:30:16 Done.
18 outline: 5px solid rgba(0, 255, 0, 0.5);
19 outline-offset: -4px;
20 overflow: scroll;
21 padding: 10px;
flackr 2016/11/15 20:40:40 nit: Remove unnecessary padding.
yigu 2016/11/15 23:30:16 Done.
22 width: 200px;
23 height: 200px;
24 box-sizing: border-box;
25 will-change: transform;
26 }
27
28 .spacer {
29 height: 300px;
30 }
31 </style>
32 <!-- #scroller should not be covered up by a negative offset outline. It is
flackr 2016/11/15 20:40:40 This comment is confusing, the outline should be o
yigu 2016/11/15 23:30:16 Yes that was misleading.
33 achieved by painting the outline into the decoration layer which draws
34 on top of all other layers. -->
35 <div id="scroller">
36 <div class="spacer"></div>
37 </div>
38
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698