Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2438863003: Fix the logging information in creating server push stream. (Closed)

Created:
4 years, 2 months ago by Zhongyi Shi
Modified:
4 years, 2 months ago
Reviewers:
Buck
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the logging information in creating server push stream. BUG= Committed: https://crrev.com/e3a2cd353ee6a818b82cbbd0a97faa3e8453f460 Cr-Commit-Position: refs/heads/master@{#426945}

Patch Set 1 #

Patch Set 2 : and some more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M net/spdy/spdy_session.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Zhongyi Shi
4 years, 2 months ago (2016-10-21 19:37:47 UTC) #2
Buck
lgtm
4 years, 2 months ago (2016-10-21 19:43:47 UTC) #3
Zhongyi Shi
Just realize that the old logging makes sense in a confusing way, rephrase the logging ...
4 years, 2 months ago (2016-10-21 19:46:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438863003/20001
4 years, 2 months ago (2016-10-21 22:28:50 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-22 01:34:14 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-22 01:35:56 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e3a2cd353ee6a818b82cbbd0a97faa3e8453f460
Cr-Commit-Position: refs/heads/master@{#426945}

Powered by Google App Engine
This is Rietveld 408576698