Continue to use _NSDrawCarbonThemeBezel to draw text field borders.

Continue to use _NSDrawCarbonThemeBezel to draw text field borders.

No intended behavior change. This CL ensures that when we bump the deployment
target, the behavior remains the same. The alternatives induce behavior changes
for minimal gain. If this ever becomes an issue, it will be easy to switch
solutions.

BUG=658085
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/b882d8b743359ef23639846613c5df1d5a2fb3da
Cr-Commit-Position: refs/heads/master@{#426688}

[erikchen, 2016-10-21 01:03:16]

Description was changed from

==========
Continue to use _NSDrawCarbonThemeBezel to draw text field borders.

No intended behavior change. This CL ensures that when we bump the deployment
target, the behavior remains the same. The alternatives induce behavior changes
for minimal gain. If this ever becomes an issue, it will be easy to switch
solutions.

BUG=658085
==========

to

==========
Continue to use _NSDrawCarbonThemeBezel to draw text field borders.

No intended behavior change. This CL ensures that when we bump the deployment
target, the behavior remains the same. The alternatives induce behavior changes
for minimal gain. If this ever becomes an issue, it will be easy to switch
solutions.

BUG=658085
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[erikchen, 2016-10-21 01:04:31]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2016-10-21 01:04:56]

erikchen@chromium.org changed reviewers:
+ thakis@chromium.org

[erikchen, 2016-10-21 01:04:57]

thakis: Please review.

[commit-bot: I haz the power, 2016-10-21 01:05:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-10-21 01:11:53]

On 2016/10/21 01:04:57, erikchen wrote:
> thakis: Please review.

Rs-lgtm

Medium term I guess we want to do what WebKit does. (Not sure if that's the same
-- you had checked for one of the two files, but on phone atm)

[erikchen, 2016-10-21 01:15:49]

On 2016/10/21 01:11:53, Nico (mostly afk until Oct 23) wrote:
> On 2016/10/21 01:04:57, erikchen wrote:
> > thakis: Please review.
> 
> Rs-lgtm
> 
> Medium term I guess we want to do what WebKit does. (Not sure if that's the
same
> -- you had checked for one of the two files, but on phone atm)

I'm going to land this so I can bump the deployment target [and since the
preprocessor conditional doesn't make any sense]. Please see crbug for more
details. I have a patch that mimics webkit's behavior - you can take a look at
that and the screenshots to decide if we should switch. I really don't like the
fact that the WebKit[AppKit] solution has different behaviors on retina and
non-retina machines.

[erikchen, 2016-10-21 01:15:53]

The CQ bit was unchecked by erikchen@chromium.org

[erikchen, 2016-10-21 01:15:53]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-10-21 01:16:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 02:13:47]

Committed patchset #1 (id:1)

[Nico, 2016-10-21 03:06:42]

Oh absolutely land this first to unblock things (hence the lg and the
"medium term") :-)

On Oct 20, 2016 9:13 PM, "commit-bot@chromium.org via
chromiumcodereview-hr.appspot.com" <
reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Committed patchset #1 (id:1)
>
> https://codereview.chromium.org/2438843003/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Nico, 2016-10-21 03:06:43]

Oh absolutely land this first to unblock things (hence the lg and the
"medium term") :-)

On Oct 20, 2016 9:13 PM, "commit-bot@chromium.org via
chromiumcodereview-hr.appspot.com" <
reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Committed patchset #1 (id:1)
>
> https://codereview.chromium.org/2438843003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-10-21 13:26:04]

Description was changed from

==========
Continue to use _NSDrawCarbonThemeBezel to draw text field borders.

No intended behavior change. This CL ensures that when we bump the deployment
target, the behavior remains the same. The alternatives induce behavior changes
for minimal gain. If this ever becomes an issue, it will be easy to switch
solutions.

BUG=658085
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Continue to use _NSDrawCarbonThemeBezel to draw text field borders.

No intended behavior change. This CL ensures that when we bump the deployment
target, the behavior remains the same. The alternatives induce behavior changes
for minimal gain. If this ever becomes an issue, it will be easy to switch
solutions.

BUG=658085
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/b882d8b743359ef23639846613c5df1d5a2fb3da
Cr-Commit-Position: refs/heads/master@{#426688}
==========

[commit-bot: I haz the power, 2016-10-21 13:26:05]

Patchset 1 (id:??) landed as
https://crrev.com/b882d8b743359ef23639846613c5df1d5a2fb3da
Cr-Commit-Position: refs/heads/master@{#426688}