Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2438773003:
Update CRD ChromeOS Host build files to be better in line with GN style. (Closed)
DescriptionUpdate CRD ChromeOS Host build files to be better in line with GN style.
Review-Url: https://codereview.chromium.org/2438773003
Cr-Commit-Position: refs/heads/master@{#467017}
Committed: https://chromium.googlesource.com/chromium/src/+/295ec60d1934341a35781704a0301fdb3cca43a3
Patch Set 1 #Patch Set 2 : Fixing up the linux source location to match chromeos. #Patch Set 3 : Cleanup linux includes from chromeos and remove a gn todo for mac. #Patch Set 4 : Fixing path for chromeos files. #Patch Set 5 : Adding desktop_capture as a dep for chromeos.: #Patch Set 6 : More fixing deps for chromeos. #Patch Set 7 : Adding dep on linux source for chromeos unit tests. #Patch Set 8 : Switching around how chromeos gets CRD host linux code. #Patch Set 9 : Merge branch 'master' into chromeos_gn #
Total comments: 6
Patch Set 10 : Updating based on feedback, adding audio_cap stub for chromeos. #Patch Set 11 : Removing enable_configuration_policy, I guess that was removed. #Patch Set 12 : Updating to new way to include gtk. #Patch Set 13 : Moving dep on gtk and adding allowed deps. #Patch Set 14 : Lost the dep on linux:x11 in merge, adding back. #Patch Set 15 : Moving unicode_to_keysym to x11, that is the only place the class is used. #
Messages
Total messages: 81 (75 generated)
The CQ bit was checked by nicholss@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nicholss@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by nicholss@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by nicholss@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by nicholss@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nicholss@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by nicholss@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #7 (id:120001) has been deleted
The CQ bit was checked by nicholss@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nicholss@chromium.org to run a CQ dry run
Patchset #7 (id:140001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nicholss@chromium.org to run a CQ dry run
The CQ bit was checked by nicholss@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
nicholss@chromium.org changed reviewers: + sergeyu@chromium.org
PTAL, the changes to move CRD ChromeOS Host build files around.
lgtm with some nits https://codereview.chromium.org/2438773003/diff/190001/build/config/linux/gtk... File build/config/linux/gtk2/BUILD.gn (right): https://codereview.chromium.org/2438773003/diff/190001/build/config/linux/gtk... build/config/linux/gtk2/BUILD.gn:30: "//remoting/host/linux:linux", nit: I think you don't need ":linux" part https://codereview.chromium.org/2438773003/diff/190001/remoting/host/BUILD.gn File remoting/host/BUILD.gn (right): https://codereview.chromium.org/2438773003/diff/190001/remoting/host/BUILD.gn... remoting/host/BUILD.gn:306: public_deps += [ "//remoting/host/linux" ] I don't think we need any of these files on ChromeOS, so maybe move it to !is_chromeos https://codereview.chromium.org/2438773003/diff/190001/remoting/host/BUILD.gn... remoting/host/BUILD.gn:506: "//remoting/host/linux", # for AudioPipeReader This shouldn't be needed. AudioCapturerLinux is compiled on ChromeOS, but it doesn't work there. It's better to exclude audio_capturer_linux.cc on chromeos and add a stub audio_capturer_chromeos.cc (which would be the same as audio_capturer_mac.cc).
The CQ bit was checked by nicholss@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
nicholss@chromium.org changed reviewers: + dpranke@google.com
Reviving this CL. Updated based on feedback. (running trybots now to see if we are still green...) +dpranke@ for build/config/linux/gtk2 changes. https://codereview.chromium.org/2438773003/diff/190001/build/config/linux/gtk... File build/config/linux/gtk2/BUILD.gn (right): https://codereview.chromium.org/2438773003/diff/190001/build/config/linux/gtk... build/config/linux/gtk2/BUILD.gn:30: "//remoting/host/linux:linux", On 2016/11/23 22:35:30, Sergey Ulanov wrote: > nit: I think you don't need ":linux" part Done. https://codereview.chromium.org/2438773003/diff/190001/remoting/host/BUILD.gn File remoting/host/BUILD.gn (right): https://codereview.chromium.org/2438773003/diff/190001/remoting/host/BUILD.gn... remoting/host/BUILD.gn:306: public_deps += [ "//remoting/host/linux" ] On 2016/11/23 22:35:30, Sergey Ulanov wrote: > I don't think we need any of these files on ChromeOS, so maybe move it to > !is_chromeos Done. https://codereview.chromium.org/2438773003/diff/190001/remoting/host/BUILD.gn... remoting/host/BUILD.gn:506: "//remoting/host/linux", # for AudioPipeReader On 2016/11/23 22:35:30, Sergey Ulanov wrote: > This shouldn't be needed. AudioCapturerLinux is compiled on ChromeOS, but it > doesn't work there. It's better to exclude audio_capturer_linux.cc on chromeos > and add a stub audio_capturer_chromeos.cc (which would be the same as > audio_capturer_mac.cc). Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nicholss@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nicholss@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nicholss@chromium.org to run a CQ dry run
nicholss@chromium.org changed reviewers: - dpranke@google.com
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
The CQ bit was checked by nicholss@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nicholss@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by nicholss@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by nicholss@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org, dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2438773003/#ps310001 (title: "Moving unicode_to_keysym to x11, that is the only place the class is used.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 310001, "attempt_start_ts": 1493138241232810,
"parent_rev": "c8aaea4fc06896f27d1d292ed16ed627b60d7fa2", "commit_rev":
"295ec60d1934341a35781704a0301fdb3cca43a3"}
Message was sent while issue was closed.
Description was changed from ========== Update CRD ChromeOS Host build files to be better in line with GN style. ========== to ========== Update CRD ChromeOS Host build files to be better in line with GN style. Review-Url: https://codereview.chromium.org/2438773003 Cr-Commit-Position: refs/heads/master@{#467017} Committed: https://chromium.googlesource.com/chromium/src/+/295ec60d1934341a35781704a030... ==========
Message was sent while issue was closed.
Committed patchset #15 (id:310001) as https://chromium.googlesource.com/chromium/src/+/295ec60d1934341a35781704a030... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
