Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2438753002: [devil] Add a prefetch interface to devil_env. (Closed)

Created:
4 years, 2 months ago by jbudorick
Modified:
4 years, 2 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove TODO #

Patch Set 3 : +1 blank line after class #

Total comments: 2

Patch Set 4 : aiolos comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M devil/devil/devil_env.py View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
M telemetry/telemetry/internal/util/binary_manager.py View 1 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jbudorick
4 years, 2 months ago (2016-10-20 14:21:54 UTC) #2
aiolos (Not reviewing)
lgtm https://codereview.chromium.org/2438753002/diff/40001/devil/devil/devil_env.py File devil/devil/devil_env.py (right): https://codereview.chromium.org/2438753002/diff/40001/devil/devil/devil_env.py#newcode188 devil/devil/devil_env.py:188: if device: Should this be arch or device?
4 years, 2 months ago (2016-10-20 16:25:25 UTC) #3
jbudorick
https://codereview.chromium.org/2438753002/diff/40001/devil/devil/devil_env.py File devil/devil/devil_env.py (right): https://codereview.chromium.org/2438753002/diff/40001/devil/devil/devil_env.py#newcode188 devil/devil/devil_env.py:188: if device: On 2016/10/20 16:25:25, aiolos wrote: > Should ...
4 years, 2 months ago (2016-10-20 16:50:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438753002/60001
4 years, 2 months ago (2016-10-20 16:51:01 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-20 17:12:32 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698