Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: telemetry/telemetry/internal/util/binary_manager.py

Issue 2438753002: [devil] Add a prefetch interface to devil_env. (Closed)
Patch Set: aiolos comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « devil/devil/devil_env.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/util/binary_manager.py
diff --git a/telemetry/telemetry/internal/util/binary_manager.py b/telemetry/telemetry/internal/util/binary_manager.py
index d3e100fd7075c15673606edba742537bb0208d60..dc8c5568f680ef7f45fa76332299725e9cefdb7b 100644
--- a/telemetry/telemetry/internal/util/binary_manager.py
+++ b/telemetry/telemetry/internal/util/binary_manager.py
@@ -132,13 +132,10 @@ def FetchBinaryDepdencies(platform, client_configs,
logging.error('Error when trying to prefetch paths for %s: %s',
target_platform, e.message)
- # TODO(aiolos, jbudorick): we should have a devil pre-fetch API to call here
- # and/or switch devil to use the same platform names so we can include it in
- # the primary loop.
if fetch_devil_deps:
devil_env.config.Initialize()
- devil_env.config._dm.PrefetchPaths(target_platform)
- devil_env.config._dm.PrefetchPaths('linux2_x86_64')
+ devil_env.config.PrefetchPaths(arch=platform.GetArchName())
+ devil_env.config.PrefetchPaths()
def _FetchReferenceBrowserBinary(platform):
« no previous file with comments | « devil/devil/devil_env.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698