Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Unified Diff: content/common/navigation_params.h

Issue 2438743005: Fix history nav to a script-injected about:blank frame. (Closed)
Patch Set: Fix nits. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/navigation_params.h
diff --git a/content/common/navigation_params.h b/content/common/navigation_params.h
index 765d3cb69dda71b29ed9e10db69ba0b7b1f8d9c5..6fd86aafcd6bcfea34dff5eabea042ce89b9adf9 100644
--- a/content/common/navigation_params.h
+++ b/content/common/navigation_params.h
@@ -7,7 +7,7 @@
#include <stdint.h>
-#include <set>
+#include <map>
#include <string>
#include "base/memory/ref_counted.h"
@@ -223,7 +223,7 @@ struct CONTENT_EXPORT RequestNavigationParams {
int nav_entry_id,
bool is_same_document_history_load,
bool is_history_navigation_in_new_child,
- std::set<std::string> subframe_unique_names,
+ std::map<std::string, bool> subframe_unique_names,
bool has_committed_real_load,
bool intended_as_new_entry,
int pending_history_list_offset,
@@ -278,13 +278,14 @@ struct CONTENT_EXPORT RequestNavigationParams {
// a URL from a session history item. Defaults to false.
bool is_history_navigation_in_new_child;
- // If this is a history navigation, this contains a set of frame unique names
- // for immediate children of the frame being navigated for which there are
- // history items. The renderer process only needs to check with the browser
- // process for newly created subframes that have these unique names.
+ // If this is a history navigation, this contains a map of frame unique names
+ // to |is_about_blank| for immediate children of the frame being navigated for
+ // which there are history items. The renderer process only needs to check
+ // with the browser process for newly created subframes that have these unique
+ // names (and only when not staying on about:blank).
// TODO(creis): Expand this to a data structure including corresponding
- // same-process PageStates as well in https://crbug.com/639842.
- std::set<std::string> subframe_unique_names;
+ // same-process PageStates for the whole subtree in https://crbug.com/639842.
+ std::map<std::string, bool> subframe_unique_names;
// Whether the frame being navigated has already committed a real page, which
// affects how new navigations are classified in the renderer process.

Powered by Google App Engine
This is Rietveld 408576698