content/browser/frame_host/navigation_request.cc - Issue 2438743005: Fix history nav to a script-injected about:blank frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 2438743005: Fix history nav to a script-injected about:blank frame. (Closed)

Patch Set: Fix nits. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_request.cc

diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc

index f6da2a7575635de29e6ca651630919a004927e40..826241b4611f195c3dbc81241fbf937818992ec9 100644

--- a/content/browser/frame_host/navigation_request.cc

+++ b/content/browser/frame_host/navigation_request.cc

@@ -189,7 +189,7 @@ std::unique_ptr<NavigationRequest> NavigationRequest::CreateRendererInitiated(

0, // nav_entry_id

false, // is_same_document_history_load

false, // is_history_navigation_in_new_child

- std::set<std::string>(), // subframe_unique_names

+ std::map<std::string, bool>(), // subframe_unique_names

frame_tree_node->has_committed_real_load(),

false, // intended_as_new_entry

-1, // pending_history_list_offset