Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2438583002: [utils] Lower kMinComplexMemCopy on 64-bit archs to 8 (Closed)

Created:
4 years, 2 months ago by Jakob Kummerow
Modified:
3 years, 10 months ago
Reviewers:
cbruni, Camillo Bruni
CC:
octavian.soldea, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[utils] Lower kMinComplexMemCopy on 64-bit archs to 8 Down from 16 * kPointerSize. Modern compilers have good inlining support for memcpy(), so our custom C++ loop is only beneficial for very short loops (if at all). BUG=v8:5395 Review-Url: https://codereview.chromium.org/2438583002 Cr-Commit-Position: refs/heads/master@{#43212} Committed: https://chromium.googlesource.com/v8/v8/+/70791d0cc3350885c48e6c7fa8b61d959602eab9

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : s/16/8/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/utils.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
Jakob Kummerow
Camillo: PTAL. See discussion at https://chromiumcodereview.appspot.com/2291773002/ for background. Octavian: FYI.
3 years, 10 months ago (2017-02-15 13:15:00 UTC) #3
cbruni
lgtm
3 years, 10 months ago (2017-02-15 13:17:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438583002/40001
3 years, 10 months ago (2017-02-15 13:22:27 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-15 13:22:29 UTC) #9
Camillo Bruni
lgtm
3 years, 10 months ago (2017-02-15 13:23:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438583002/40001
3 years, 10 months ago (2017-02-15 13:24:20 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 13:51:49 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/70791d0cc3350885c48e6c7fa8b61d95960...

Powered by Google App Engine
This is Rietveld 408576698