Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(19)

Issue 2438543002: [ozone/wayland] gn gen --check <out> fails (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year ago by tonikitoo
Modified:
1 year ago
Reviewers:
rjkroege, fwang, spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, fwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ozone/wayland] gn gen --check <out> fails Generating files... ERROR at //ui/ozone/platform/wayland/ozone_platform_wayland.cc:8:11: Can't include this header from here. ^--------------------------------- The target: //ui/ozone/platform/wayland:wayland is including a file from the target: /ui/display:display Committed: https://crrev.com/020ba5fd0cbad53697c090c0df9cead51bdb14a7 Cr-Commit-Position: refs/heads/master@{#426206}

Patch Set 1 #

Messages

Total messages: 10 (4 generated)
tonikitoo
PTAL
1 year ago (2016-10-19 14:31:04 UTC) #2
fwang
informal l g t m
1 year ago (2016-10-19 14:33:46 UTC) #4
spang
lgtm
1 year ago (2016-10-19 14:53:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438543002/1
1 year ago (2016-10-19 14:53:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
1 year ago (2016-10-19 15:53:56 UTC) #8
commit-bot: I haz the power
1 year ago (2016-10-21 13:08:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/020ba5fd0cbad53697c090c0df9cead51bdb14a7
Cr-Commit-Position: refs/heads/master@{#426206}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa